-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Intel Sapphire Rapids support to archdetect #889
Draft
bedroge
wants to merge
5
commits into
EESSI:2023.06-software.eessi.io
Choose a base branch
from
bedroge:archdetect_sapphire_rapids
base: 2023.06-software.eessi.io
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cc2e00f
add Intel Sapphire/Emerald Rapids
bedroge 40e1eac
add Intel Sapphire Rapids to matrix
bedroge 670a87e
files for testing Sapphire Rapids support
bedroge d182f77
rename sapphire_rapids to sapphirerapids
bedroge 9aeb37e
rename sapphire_rapids to sapphirerapids
bedroge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| # x86_64 CPU architecture specifications | ||
| # Software path in EESSI | Vendor ID | List of defining CPU features | ||
| "x86_64/intel/haswell" "GenuineIntel" "avx2 fma" # Intel Haswell, Broadwell | ||
| "x86_64/intel/skylake_avx512" "GenuineIntel" "avx2 fma avx512f avx512bw avx512cd avx512dq avx512vl" # Intel Skylake, Cascade Lake | ||
| "x86_64/amd/zen2" "AuthenticAMD" "avx2 fma" # AMD Rome | ||
| "x86_64/amd/zen3" "AuthenticAMD" "avx2 fma vaes" # AMD Milan, Milan-X | ||
| "x86_64/amd/zen4" "AuthenticAMD" "avx2 fma vaes avx512f avx512ifma" # AMD Genoa, Genoa-X | ||
| "x86_64/intel/haswell" "GenuineIntel" "avx2 fma" # Intel Haswell, Broadwell | ||
| "x86_64/intel/skylake_avx512" "GenuineIntel" "avx2 fma avx512f avx512bw avx512cd avx512dq avx512vl" # Intel Skylake, Cascade Lake | ||
| "x86_64/intel/sapphire_rapids" "GenuineIntel" "avx2 fma avx512f avx512bw avx512cd avx512dq avx512vl avx512_bf16 amx_tile" # Intel Sapphire/Emerald Rapids | ||
| "x86_64/amd/zen2" "AuthenticAMD" "avx2 fma" # AMD Rome | ||
| "x86_64/amd/zen3" "AuthenticAMD" "avx2 fma vaes" # AMD Milan, Milan-X | ||
| "x86_64/amd/zen4" "AuthenticAMD" "avx2 fma vaes avx512f avx512ifma" # AMD Genoa, Genoa-X | ||
1 change: 1 addition & 0 deletions
1
tests/archdetect/x86_64/intel/sapphire_rapids/AWS-Rocky8-8488C.all.output
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| x86_64/intel/sapphire_rapids:x86_64/intel/skylake_avx512:x86_64/intel/haswell:x86_64/generic |
26 changes: 26 additions & 0 deletions
26
tests/archdetect/x86_64/intel/sapphire_rapids/AWS-Rocky8-8488C.cpuinfo
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| processor : 0 | ||
| vendor_id : GenuineIntel | ||
| cpu family : 6 | ||
| model : 143 | ||
| model name : Intel(R) Xeon(R) Platinum 8488C | ||
| stepping : 8 | ||
| microcode : 0x2b000620 | ||
| cpu MHz : 2400.000 | ||
| cache size : 107520 KB | ||
| physical id : 0 | ||
| siblings : 16 | ||
| core id : 0 | ||
| cpu cores : 8 | ||
| apicid : 0 | ||
| initial apicid : 0 | ||
| fpu : yes | ||
| fpu_exception : yes | ||
| cpuid level : 31 | ||
| wp : yes | ||
| flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq monitor ssse3 fma cx16 pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves avx_vnni avx512_bf16 wbnoinvd ida arat avx512vbmi umip pku ospke waitpkg avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq rdpid cldemote movdiri movdir64b md_clear serialize amx_bf16 avx512_fp16 amx_tile amx_int8 flush_l1d arch_capabilities | ||
| bugs : spectre_v1 spectre_v2 spec_store_bypass swapgs eibrs_pbrsb bhi | ||
| bogomips : 4800.00 | ||
| clflush size : 64 | ||
| cache_alignment : 64 | ||
| address sizes : 46 bits physical, 48 bits virtual | ||
| power management: |
1 change: 1 addition & 0 deletions
1
tests/archdetect/x86_64/intel/sapphire_rapids/AWS-Rocky8-8488C.output
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| x86_64/intel/sapphire_rapids |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to change this to
sapphirerapidsto be consistent with archspec's naming? It would require a symlink (or complete rebuild...) for the already built packages.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh... No strong preference, I guess.
A rebuild just to remove a
_is a bit extreme, of course.A symlink is easy, but less clean.
I'm not sure we should 100% stick to the archspec naming, although that does sort of make sense I guess.
In short: ask others for input here ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of our CI will break if the names don't align...but we also need #485 to make sure
archspecis up to date for architectures