Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when defining multiple modules in app.cfg #908

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Fix bug when defining multiple modules in app.cfg #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
109dbef
Fix bug when multiple modules where defined. In the old syntax, they …
Feb 5, 2025
b56c708
Also fix in test.sh
Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bot/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ mkdir -p ${SINGULARITY_TMPDIR}

# load modules if LOAD_MODULES is not empty
if [[ ! -z ${LOAD_MODULES} ]]; then
for mod in $(echo ${LOAD_MODULES} | tr ',' '\n')
IFS=',' read -r -a modules <<< "$(echo "${LOAD_MODULES}")"
for mod in "${modules[@]}";
do
echo "bot/build.sh: loading module '${mod}'"
module load ${mod}
Expand Down
3 changes: 2 additions & 1 deletion bot/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ mkdir -p ${SINGULARITY_TMPDIR}

# load modules if LOAD_MODULES is not empty
if [[ ! -z ${LOAD_MODULES} ]]; then
for mod in $(echo ${LOAD_MODULES} | tr ',' '\n')
IFS=',' read -r -a modules <<< "$(echo "${LOAD_MODULES}")"
for mod in "${modules[@]}";
do
echo "bot/test.sh: loading module '${mod}'"
module load ${mod}
Expand Down