Fix behavior for present but failing nvidiasmi #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 10, 2025 19:00
…. The command will exist, but return a non-zero exit when run with .e.g --version because there are no GPU drivers
…. The command will exist, but return a non-zero exit when run with .e.g --version because there are no GPU drivers
…. The command will exist, but return a non-zero exit when run with .e.g --version because there are no GPU drivers
|
Instance
|
|
Instance
|
|
Instance
|
|
Instance
|
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
|
PR merged! Moved |
|
Lots of copy-pasting, can we consider moving this check into a utility function so we don't have this duplicate code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some cpu nodes on which the nvidia-smi command is installed, but failing
I.e. simply checking for the presence of
nvidia-smiand then concluding that GPUs are available (as we did prior to this PR) is not very robust. Sincenvidia-smidoes give a non-zero exit code in this case, it's pretty easy to improve the robustness of the check, which is done in this PR.