Update teout standard name for check_energy; bring in check_energy diagnostic output #339
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmielin
added
the
code clean-up
jimmielin
added a commit
to ESCOMP/atmospheric_physics
that referenced
this pull request
Feb 14, 2025
…name update (#169) Originator(s): @jimmielin Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): * Fixes #161: Add check_energy related history output variables to check_energy_diagnostics * Fixes #166: Need to remove old CAM suite definition files * Fixes #176 (updates `teout` standard name to `vertically_integrated_total_energy_using_dycore_energy_formula_at_end_of_physics_timestep`) Companion PR in SIMA: ESCOMP/CAM-SIMA#339 Describe any changes made to the namelist: N/A List all files eliminated and why: ``` Fix #166 to remove old SDF files from scoping exercise D suites/suite_cam4.xml D suites/suite_cam6.xml D suites/suite_cam6_silhs.xml ``` List all files added and what they do: ``` Add global energy fixer diagnostics (teinp, teout, tefix, efix) A schemes/sima_diagnostics/check_energy_fix_diagnostics.F90 A schemes/sima_diagnostics/check_energy_fix_diagnostics.meta ``` List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) ``` Move some developments to check_energy_fix_diagnostics so they can be called at right time. M schemes/sima_diagnostics/check_energy_diagnostics.F90 M schemes/sima_diagnostics/check_energy_diagnostics.meta Add call to check_energy_fix_diagnostics in schemes using global energy fixer: M suites/suite_adiabatic.xml M suites/suite_cam7.xml Update teout standard name M doc/NamesNotInDictionary.txt M schemes/check_energy/check_energy_chng.meta M schemes/check_energy/check_energy_gmean/check_energy_gmean.meta M schemes/check_energy/check_energy_save_teout.meta M schemes/sima_diagnostics/check_energy_diagnostics.F90 M schemes/sima_diagnostics/check_energy_diagnostics.meta M schemes/sima_diagnostics/check_energy_gmean_diagnostics.meta ``` List any test failures: N/A Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? N/A (diagnostics change only)
…rgy; thermo_water_update wrapper)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches): sima0_03_000
Originator(s): @jimmielin
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Closes ESCOMP/atmospheric_physics#161, ESCOMP/atmospheric_physics#166, ESCOMP/atmospheric_physics#176:
Companion PRs:
Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: