Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restart read/write for dglc%noevolve #306

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

mvertens
Copy link
Collaborator

@mvertens mvertens commented Sep 2, 2024

Description of changes

Add restart functionality for DGLC%NOEVOLVE

Specific notes

This fixes the problem that restarts from year boundaries set the Fgrg_rofi to zero for the following year.

Contributors other than yourself, if any: None

CDEPS Issues Fixed: #305

Are there dependencies on other component PRs (if so list): None

Are changes expected to change answers (bfb other than , different to roundoff, more substantial):

Any User Interface Changes: None

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): Ran full coupled cases for NorESM with DGLC%NOEVOLVE and showed that read and writing restarts fixed the problem outlined in #305.

Hashes used for testing:

@mvertens mvertens added bug Something isn't working Critical labels Sep 2, 2024
@mvertens mvertens requested review from billsacks and Katetc September 2, 2024 17:44
@mvertens
Copy link
Collaborator Author

mvertens commented Sep 2, 2024

@Katetc @billsacks - I think this PR needs to be put in place as soon as possible since the current production runs using DGLC%NOEVOLVE are not restart correctly on year boundaries.

Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for noticing and fixing this issue, @mvertens !!!

Copy link
Contributor

@Katetc Katetc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mariana! Looks good to me.

@jedwards4b jedwards4b merged commit 5020df6 into ESCOMP:main Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dglc%noevolve does not restart correctly on year boundaries
4 participants