Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace calls to esmf_logmsg_error with shr_abort #320

Merged

Conversation

jedwards4b
Copy link
Contributor

Description of changes

Replace calls to esmf_logwrite which are abort messages with calls to shr_sys_abort which now includes the esmf_logwrite call.

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial):

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

Hashes used for testing:

@jedwards4b jedwards4b self-assigned this Jan 23, 2025
@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Jan 23, 2025

@jedwards4b I think needs a cesm_share update (?). Is that in a branch somewhere (apologies if I'm mixed up---lots of balls in the air).

@jedwards4b
Copy link
Contributor Author

The cesm_share code is copied into the share directory of cdeps for you.

@jedwards4b
Copy link
Contributor Author

@DeniseWorthen the share code that you need is in the share directory of this repo.

@DeniseWorthen
Copy link
Collaborator

I needed to add a use statement here to get it to compile:

diff --git a/docn/docn_import_data_mod.F90 b/docn/docn_import_data_mod.F90
index 150d15e4..1037493f 100644
--- a/docn/docn_import_data_mod.F90
+++ b/docn/docn_import_data_mod.F90
@@ -70,6 +70,8 @@ contains
    !===============================================================================
    subroutine docn_get_import_fields(str, flds, rc)

+     use shr_sys_mod          , only : shr_sys_abort
+

@jedwards4b
Copy link
Contributor Author

Good catch, thank you.

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in UFS. Thanks.

@jedwards4b jedwards4b merged commit baa3024 into ESCOMP:main Jan 24, 2025
1 check passed
@jedwards4b jedwards4b deleted the replace_esmf_logmsg_error_shr_abort branch January 24, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants