Adds a broadcast of the namelist value 'urbantvmapalgo' #2534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it in so it is consistent across all ranks when not using the default value ('nn').
billsacks
approved these changes
May 9, 2024
Member
billsacks
left a comment
billsacks
left a comment
There was a problem hiding this comment.
Thanks for the fix @briandobbins !
ekluzek
approved these changes
May 16, 2024
Collaborator
|
@briandobbins I'm rebasing this to come in on b4b-dev, so it can come in quicker. |
ekluzek
added
enhancement
… it in so it is consistent across all ranks when not using the default value ('nn').
Contributor
|
Is this ready to merge? |
Member
|
@briandobbins Would you mind rebasing this onto ctsm5.3.0 and force-pushing? Not a big deal, but makes it clearer exactly what files are being changed. I tested |
samsrabin
added
good first issue
Member
|
@briandobbins Rebase no longer needed; I'll start testing now. |
ekluzek
changed the title
…than the MCT namelist list fixing ESCOMP#1912
…options for mapping are used
…s/CTSM into fix_urbantvmapalgo_broadcast Conflicts: bld/namelist_files/namelist_definition_ctsm.xml
Collaborator
|
I created a branch of this that I'll bring in as a separate PR, on top of this one. But, I'll update, do some testing, and merge this in now, so I can use it for the decomp_init work. |
Conflicts: bld/unit_testers/build-namelist_test.pl
…nd set ndep to redist since it's at the same resolution
…rning on the prigent streams on as well
…hough it isn't needed
…the code so they can be used, also do some veritical alignment for the mapalgo options which should help readability for this text for users
github-project-automation
bot
moved this from In progress - b4b-dev
to Done (non release/external)
in CTSM: Upcoming tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a broadcast of the namelist value for a few mapalgo items after reading it in so it is consistent across all ranks when not using the default value. Also update the mapalgo options list to be consistent with the NUOPC options, the MCT list was in place before this.
Description of changes
Simple one-line change; a namelist value wasn't being shared with ranks other than the main one reading the namelist. This lead to hangs when trying a different algorithm.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #2533 (Done)
Also fixes #3345 (Done)
Also fixes #1912 (Done)
Are answers expected to change (and if so in what way)?
No
Any User Interface Changes (namelist or namelist defaults changes)?
No
Does this create a need to change or add documentation? Did you do so?
No
Testing performed, if any:
Limited testing, but it's a one-line logical change. If more is needed, let me know. I just did a simple test with and without the change, looking at the values on all ranks.