Skip to content

ctsm5.3.053: Fix and improve anomaly forcings for ISSP cases #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samsrabin merged 57 commits into from
May 31, 2025
Merged

ctsm5.3.053: Fix and improve anomaly forcings for ISSP cases #2686

samsrabin merged 57 commits into from
May 31, 2025

Conversation

@samsrabin
Copy link
Member

@samsrabin samsrabin commented Aug 13, 2024 •
edited
Loading

Description of changes

Fixes a bug, and also makes it much simpler to run land-only SSP cases. Depends on ESCOMP/CDEPS#292.

Specific notes

Contributors other than yourself, if any: @ekluzek

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? Yes, for cases that were being bitten by #2301 before.

Any User Interface Changes (namelist or namelist defaults changes)? Yes; see ESCOMP/CDEPS#292.

Does this create a need to change or add documentation? Did you do so? Yes; yes.

  • Update docs

Testing performed, if any:

  • Existing datm_rcp45_anom_forc test unaffected as of 4b96267.
  • Existing datm_ssp126_anom_forc test unaffected as of c4ec313.

Remaining work after merging ctsm5.3.052:

  • Run ssp test suite
  • Run the three ctsm_sci tests that were failing.
  • Handle the fact that those are still failing due to CDEPS not liking CRU-JRA
  • In progress Run aux_clm test suite (with --skip-tests-with-existing-baselines)
  • Fix aux_clm NEON tests (done with 21bb0dc) and rerun on both Derecho and Izumi

samsrabin added 16 commits May 3, 2024 15:08
@samsrabin
Point CDEPS external at cdeps1.0.33.
208c594
@samsrabin
Update other externals after CESM tag cesm2_3_alpha17e.
8d628f2
@samsrabin
Add datm_rcp45_anom_forc testmod.
702477d
@samsrabin
Point CDEPS external at my branch, with Anomaly.Forcing.cmip5.rcp45.
f59d045
@samsrabin
datm_rcp45_anom_forc testmod now uses Anomaly.Forcing.cmip5.rcp45.
662e536 
Instead of having to specify anomaly_forcing = 'Anomaly.Forcing.Precip', 'Anomaly.Forcing.Temperature', etc.
@samsrabin
Added a few scripts for this work
8df08ff
@samsrabin
Remove user_nl_datm_streams from datm_rcp45_anom_forc testmod.
1416363
@samsrabin
Update CDEPS external to 462c7a9.
4b96267 
Branch ssp-fix: Fix more typos of "anomaly."
@samsrabin
Update CDEPS external to 759c591.
825fbb6 
Branch ssp-fix: Add Anomaly.Forcing.cmip6.ssp126.
@samsrabin
datm_ssp126_anom_forc testmod now uses Anomaly.Forcing.cmip6.ssp126.
496c154
@samsrabin
Add 'ssp' test suite.
0a8df10
@samsrabin
Update CDEPS external to 84669d7.
634cfce 
ssp-fix branch: Add Anomaly.Forcing.cmip6.245, 370, 585.
@samsrabin
Add testmods for ssp245, 370, 585.
42b7575
@samsrabin
Add ssp suite tests for 245, 370, 585.
567fcad
@samsrabin
Merge remote-tracking branch 'escomp/b4b-dev' into ssp-anomaly-fixes
597a4de
@samsrabin
Update CDEPS external to 547506603e.
c4ec313 
Branch ssp-fix: Merge tag 'cdeps1.0.34' into ssp-fix
@samsrabin samsrabin added the bug something is working incorrectly label Aug 13, 2024
@samsrabin samsrabin self-assigned this Aug 13, 2024
@samsrabin samsrabin added the usability Improve or clarify user-facing options label Aug 27, 2024
@samsrabin
Update CDEPS external to 3f36622.
49382ee 
Branch ssp-fix: "anomaly_forcing now automatically set based on compset (ISSP*)." Also updates testmods accordingly.
@samsrabin
Update CDEPS external to 797b320.
728257b 
Branch ssp-fix: Now actually sets anomaly_forcing based on compset.
@samsrabin samsrabin removed the PR status: awaiting review Work on this PR is paused while waiting for review. label May 14, 2025
ekluzek added a commit to ekluzek/CTSM that referenced this pull request May 14, 2025
@ekluzek
Remove the SMS_D_Ld5.f09_g17.ISSP126Clm50BgcCrop.derecho_intelclm-dat…
c703028 
…m_ssp126_anom_forc test because it no longer works, and the changes in ESCOMP#2686 handle it
@samsrabin samsrabin changed the title Fix and improve anomaly forcings for ISSP cases ctsm5.3.048: Fix and improve anomaly forcings for ISSP cases May 19, 2025
@samsrabin samsrabin changed the title ctsm5.3.048: Fix and improve anomaly forcings for ISSP cases ctsm5.3.049: Fix and improve anomaly forcings for ISSP cases May 19, 2025
@ekluzek ekluzek changed the title ctsm5.3.049: Fix and improve anomaly forcings for ISSP cases ctsm5.3.05?: Fix and improve anomaly forcings for ISSP cases May 22, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented May 28, 2025

In ctsm5.3.050 these three ctsm_sci SSP tests fail:

SMS_Ld5.f09_t232.ISSP245Clm60BgcCropCrujra.derecho_intel.clm-ciso_dec2050Start	(SETUP)		
SMS_Ld5.f09_t232.ISSP370Clm60BgcCropCrujra.derecho_intel.clm-ciso_dec2050Start	(SETUP)		
SMS_Ld5.f09_t232.ISSP585Clm60BgcCropCrujra.derecho_intel.clm-ciso_dec2050Start	(SETUP)

I'm marking this as the reason for it, as bringing this in will fix it.

ekluzek added a commit to ekluzek/CTSM that referenced this pull request May 28, 2025
@ekluzek
Add three ctsm_sci SSP tests to expected fails, because they need ESC…
851c481 
…OMP#2686 brought in
@samsrabin samsrabin changed the title ctsm5.3.05?: Fix and improve anomaly forcings for ISSP cases ctsm5.3.053: Fix and improve anomaly forcings for ISSP cases May 30, 2025
@samsrabin
Merge tag 'ctsm5.3.052' into ssp-anomaly-fixes
f1ee329 
Changes to MEGAN needed for coupled cases

Corrections on how MEGAN coefficients are applied.

Depends on the cmeps tag cmeps1.1.1
@samsrabin samsrabin changed the base branch from master to b4b-dev May 30, 2025 18:02
@samsrabin samsrabin changed the base branch from b4b-dev to master May 30, 2025 18:02
@samsrabin samsrabin force-pushed the ssp-anomaly-fixes branch from 7a76662 to 93e847a Compare May 30, 2025 19:54
@samsrabin samsrabin added docs:update Significant update or fix needed to existing documentation docs-loc:users-guide Relates to User's Guide (using CTSM/tools) labels May 30, 2025
@samsrabin samsrabin merged commit 4434801 into ESCOMP:master May 31, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags May 31, 2025
@samsrabin samsrabin mentioned this pull request May 31, 2025
Closed
mvdebolskiy added a commit to mvdebolskiy/CTSM that referenced this pull request Jun 14, 2025
@mvdebolskiy
Merge pull request ESCOMP#2686 from samsrabin/ssp-anomaly-fixes
7442c04 
ctsm5.3.053: Fix and improve anomaly forcings for ISSP cases

(cherry picked from commit 4434801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekluzek ekluzek ekluzek approved these changes

Assignees

@samsrabin samsrabin

Labels

blocker another issue/PR depends on this one bug something is working incorrectly docs:update Significant update or fix needed to existing documentation docs-loc:users-guide Relates to User's Guide (using CTSM/tools) enhancement new capability or improved behavior of existing capability external issue needs to be addressed elsewhere (submodule); issue here for the sake of project tracking usability Improve or clarify user-facing options

Projects

CTSM: Upcoming tags
Status: Done (non release/external)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SSP cases get rcp45 anomalies Example, user_nl_datm_streams file for anomaly forcing for NUOPC coupler Turn on anomaly forcing for ISSP compsets

3 participants

@samsrabin @ekluzek @wwieder