Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fates two-stream restart fixes #2949

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rgknox
Copy link
Collaborator

@rgknox rgknox commented Feb 3, 2025

Description of changes

This set of changes corrects some issues with restarting FATES two-stream radiation. It also changes how zenith angles are updated and passed to FATES. Specifically, zenith angles are allowed to be calculated when FATES is active even if doalb = .false., which overcomes a miscue during branch runs. All FATES two-stream restart tests pass with this update.

Synchronize with FATES #1321.

Specific notes

Contributors other than yourself, if any:

@ckoven

CTSM Issues Fixed (include github issue #):

Fixes: #2325

Are answers expected to change (and if so in what way)?

No

Any User Interface Changes (namelist or namelist defaults changes)?

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@rgknox rgknox changed the title Fates branch rest fixes Fates two-stream restart fixes Feb 3, 2025
@rgknox rgknox added the FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM label Feb 4, 2025
@slevis-lmwg
Copy link
Contributor

Any chance this relates to the branch problem that you're encountering in your PR @rgknox?
#2903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERS FatesColdTwoStreamNoCompFixedBioGeo Restart Test Fails
2 participants