-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CRUJRA2024 the default datm input for Clm6 plus add a corresponding compset for Clm5 #2956
Draft
slevis-lmwg
wants to merge
8
commits into
ESCOMP:master
Choose a base branch
from
slevis-lmwg:mk_crujra_default
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevis-lmwg
added
enhancement
new capability or improved behavior of existing capability
priority: high
High priority to fix/merge soon, e.g., because it is a problem in important configurations
usability
Improve or clarify user-facing options
PR status: needs testing
non-bfb
Changes answers (incl. adding tests)
labels
Feb 6, 2025
First attempt at testing: |
Second set of tests on derecho:
Checked the last two suites with these commands:
In aux_cdeps, this test fails here but also in vanilla ctsm5.3.021:
|
3rd round to test the "clm5" changes
|
TODOs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
new capability or improved behavior of existing capability
non-bfb
Changes answers (incl. adding tests)
PR status: needs testing
priority: high
High priority to fix/merge soon, e.g., because it is a problem in important configurations
usability
Improve or clarify user-facing options
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Change the default datm input from GSWP3v1 to CRUJRA2024 for Clm6.
Add a CRUJRA2024 compset for clm5.
See #1895 for definition of DONE.
Specific notes
Contributors other than yourself (I hope I didn't forget any):
@wwieder @adrifoster @swensosc @djk2120 @ekluzek @olyson
CTSM Issues Fixed (include github issue #):
Resolves #1895
Are answers expected to change (and if so in what way)?
Yes, because Clm6 tests that do not specify the datm input will now get CRUJRA2024 instead of GSWP3v1.
Any User Interface Changes (namelist or namelist defaults changes)?
Adding Crujra to compset names.
Adding 2 new tests that explicitly include Crujra in their compset names.
All Clm60 tests that do not include a datm option in their compset will now default to Crujra.
Does this create a need to change or add documentation? Did you do so?
It does, and I did not, yet.
Testing performed, if any:
See relevant posts below.