Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CRUJRA2024 the default datm input for Clm6 plus add a corresponding compset for Clm5 #2956

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Feb 6, 2025

Description of changes

Change the default datm input from GSWP3v1 to CRUJRA2024 for Clm6.
Add a CRUJRA2024 compset for clm5.

See #1895 for definition of DONE.

Specific notes

Contributors other than yourself (I hope I didn't forget any):
@wwieder @adrifoster @swensosc @djk2120 @ekluzek @olyson

CTSM Issues Fixed (include github issue #):
Resolves #1895

Are answers expected to change (and if so in what way)?
Yes, because Clm6 tests that do not specify the datm input will now get CRUJRA2024 instead of GSWP3v1.

Any User Interface Changes (namelist or namelist defaults changes)?
Adding Crujra to compset names.
Adding 2 new tests that explicitly include Crujra in their compset names.
All Clm60 tests that do not include a datm option in their compset will now default to Crujra.

Does this create a need to change or add documentation? Did you do so?
It does, and I did not, yet.

Testing performed, if any:
See relevant posts below.

@slevis-lmwg slevis-lmwg self-assigned this Feb 6, 2025
@slevis-lmwg slevis-lmwg added enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations usability Improve or clarify user-facing options PR status: needs testing non-bfb Changes answers (incl. adding tests) labels Feb 6, 2025
@slevis-lmwg slevis-lmwg added this to the ctsm5.4.0: CMIP7 Datasets milestone Feb 6, 2025
@slevis-lmwg
Copy link
Contributor Author

First attempt at testing:
./create_test ERP_P128x2_Ld30.f45_f45_mg37.I2000Clm60FatesSpCrujraRsGs.derecho_intel.clm-FatesColdSatPhen

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Feb 7, 2025

Second set of tests on derecho:

OK make black & lint (the latter gives two warnings)
PASS python
PASS ./build-namelist_test.pl
OK ./run_sys_tests -s aux_clm -c ctsm5.3.021 --skip-generate
OK? ./run_sys_tests -s aux_cdeps -c /glade/campaign/cesm/cesmdata/cseg/cesm_baselines/cdeps1.0.55 --skip-generate

Checked the last two suites with these commands:

./cs.status.fails | grep -v PASS | grep -v NLCOM | grep -v '21: DIF'
./cs.status.fails | grep -v NLCOMP

In aux_cdeps, this test fails here but also in vanilla ctsm5.3.021:

SMS_D_Ld3.f10_f10_ais8gris4_mg37.DATAMODELTEST.derecho_gnu
ERROR: Invalid compset name, DATAMODELTEST, all stub components generated

@slevis-lmwg
Copy link
Contributor Author

3rd round to test the "clm5" changes

PASS ./build-namelist_test.pl
PASS ./create_test ERP_P128x2_Ld30.f45_f45_mg37.I1850Clm50BgcCropCrujra.derecho_intel.clm-default

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Feb 8, 2025

TODOs

  • Go over with @ekluzek
  • Update to latest on master here and in cdeps
  • Submit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability non-bfb Changes answers (incl. adding tests) PR status: needs testing priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations usability Improve or clarify user-facing options
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to CRU-JRA as default datm inputs for CTSM development
1 participant