Skip to content

Isoprene soil moisture options for MEGAN #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ekluzek merged 15 commits into from
Jul 25, 2025
Merged

Isoprene soil moisture options for MEGAN #3309

ekluzek merged 15 commits into from
Jul 25, 2025

Conversation

@fvitt
Copy link
Contributor

@fvitt fvitt commented Jul 7, 2025 •
edited by ekluzek
Loading

Description of changes

Implement namelist options for soil moisture activation factor used in MEGAN isoprene emissions

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #3016

Are answers expected to change (and if so in what way)? Only when turned on

Any User Interface Changes (namelist or namelist defaults changes)?

Two new CTSM megan_opts namelist items:
megan_use_gamma_sm
megan_min_gamma_sm

Does this create a need to change or add documentation? Did you do so?

Testing performed, if any: aux_clm on Derecho and Izumi as usual

@fvitt
Isoprene soil moisture options
8a9e312 
	modified:   bld/namelist_files/namelist_definition_drv_flds.xml
	modified:   src/biogeochem/VOCEmissionMod.F90
wwieder
wwieder approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@wwieder wwieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening up this PR, @fvitt .

@ekluzek see my comments / questions on the cdeps side of this PR for staging. I'm also not sure what timeline is needed for bringing this into a CESM tag?

@wwieder wwieder mentioned this pull request Jul 7, 2025
Closed
@ekluzek ekluzek added bfb bit-for-bit enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science labels Jul 8, 2025
@ekluzek ekluzek added this to the cesm3_0_beta07 milestone Jul 8, 2025
@ekluzek
Copy link
Collaborator

ekluzek commented Jul 8, 2025

@fvitt there's two primary questions I have here.

  1. If the naemlist items need to be in CDEPS or if they can be local to CTSM?
  2. What additional testing should look like for this?

Minimally we need to run the test list to ensure answers are b4b with the change as we expect. And we should run at least one test (if not the whole test list) with it turned on to make sure it works with the change.

@fvitt
Copy link
Contributor Author

fvitt commented Jul 8, 2025

As @ekluzek suggests, the namelist options should probably be implemented in CTSM rather than in CMEPS

@fvitt
Move the gamma_sm options from CMEPS to CTSM
36edc66 
        modified:   bld/namelist_files/namelist_definition_drv_flds.xml
        modified:   bld/CLMBuildNamelist.pm
        modified:   bld/namelist_files/namelist_definition_ctsm.xml
        modified:   src/biogeochem/VOCEmissionMod.F90
        modified:   src/main/clm_instMod.F90
wwieder
wwieder reviewed Jul 8, 2025
View reviewed changes
Copy link
Contributor

@wwieder wwieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this into a clm namelist change, Francis.

@wwieder
Copy link
Contributor

wwieder commented Jul 10, 2025

@fvitt are you ready for us to review (and merge) this PR?

@fvitt
Copy link
Contributor Author

fvitt commented Jul 10, 2025

@fvitt are you ready for us to review (and merge) this PR?

Yes I am ready for review. Shawn is testing.

ekluzek
ekluzek approved these changes Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. This could go on b4b-dev.

@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Jul 15, 2025
@ekluzek ekluzek moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Jul 15, 2025
@ekluzek ekluzek moved this from Todo to In Progress in LMWG: Sprint Planning Board Jul 22, 2025
@ekluzek ekluzek moved this from In Progress to Done in LMWG: Sprint Planning Board Jul 22, 2025
@ekluzek ekluzek changed the base branch from master to b4b-dev July 24, 2025 00:50
@ekluzek
Merge branch 'b4b-dev' into isop_sm_factor
4f23151 
 Conflicts:
	bld/unit_testers/build-namelist_test.pl
@ekluzek
Copy link
Collaborator

ekluzek commented Jul 24, 2025

Some tests are showing a difference in answers of what looks like roundoff level.

I'm trying setting

megan_min_gamma_sm = -5.e-14

to see if it's something about rounding below zero.

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 24, 2025
@ekluzek ekluzek moved this from In progress - master to In progress - b4b-dev in CTSM: Upcoming tags Jul 24, 2025
@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 24, 2025
@ekluzek ekluzek merged commit f783875 into ESCOMP:b4b-dev Jul 25, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In progress - b4b-dev to Done (non release/external) in CTSM: Upcoming tags Jul 25, 2025
@ekluzek ekluzek deleted the isop_sm_factor branch July 25, 2025 06:09
@ekluzek ekluzek mentioned this pull request Jul 25, 2025
Merged
@wwieder
Copy link
Contributor

wwieder commented Jul 25, 2025

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wwieder wwieder wwieder approved these changes

@ekluzek ekluzek ekluzek approved these changes

Assignees

@ekluzek ekluzek

Labels

bfb bit-for-bit enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations science Enhancement to or bug impacting science

Projects

CTSM: Upcoming tags
Status: Done (non release/external)
LMWG: Sprint Planning Board
Status: Done

Milestone

cesm3_0_beta07

Development

Successfully merging this pull request may close these issues.

Low MEGAN emissions in CESM3

3 participants

@fvitt @ekluzek @wwieder