Skip to content

Remove flexCN_FUN_BNF test and testmods as redundant #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slevis-lmwg merged 1 commit into from
Jul 15, 2025
Merged

Remove flexCN_FUN_BNF test and testmods as redundant #3329

slevis-lmwg merged 1 commit into from
Jul 15, 2025

Conversation

@slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Jul 11, 2025

Description of changes

One test removed.

Specific notes

CTSM Issues Fixed (include github issue #):
Resolves #2983

Are answers expected to change (and if so in what way)?
No

@slevis-lmwg slevis-lmwg changed the base branch from master to b4b-dev July 11, 2025 04:08
@slevis-lmwg slevis-lmwg self-assigned this Jul 11, 2025
@slevis-lmwg slevis-lmwg added testing additions or changes to tests bfb bit-for-bit labels Jul 11, 2025
@slevis-lmwg slevis-lmwg added this to the ctsm6.0.0 (code freeze) milestone Jul 11, 2025
@slevis-lmwg slevis-lmwg requested a review from wwieder July 11, 2025 04:11
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Jul 11, 2025

@wwieder I requested your review due to your involvement with BNF. It should take you five minutes:
The PR removes the now redundant BNF test and testmods, as per issue #2983.
It's going to b4b-dev.

@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Jul 11, 2025 •
edited
Loading

Seems like overkill, but testing with
./run_sys_tests -s aux_clm -c ctsm5.3.063 --skip-generate

  • derecho
  • izumi

@slevis-lmwg slevis-lmwg marked this pull request as ready for review July 11, 2025 17:33
@slevis-lmwg slevis-lmwg added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete PR status: awaiting review Work on this PR is paused while waiting for review. size: small labels Jul 11, 2025
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Jul 11, 2025
@slevis-lmwg slevis-lmwg moved this from Ready to start (or start again) to In progress - b4b-dev in CTSM: Upcoming tags Jul 11, 2025
ekluzek
ekluzek approved these changes Jul 14, 2025
View reviewed changes
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. We now have BNF default on for clm6_0, and off for clm5_0 and clm4_5, so both ways are tested.

@github-project-automation github-project-automation bot moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Jul 14, 2025
@slevis-lmwg slevis-lmwg removed the PR status: awaiting review Work on this PR is paused while waiting for review. label Jul 15, 2025
@slevis-lmwg slevis-lmwg merged commit da587af into ESCOMP:b4b-dev Jul 15, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Jul 15, 2025
@slevis-lmwg slevis-lmwg deleted the redundant_bnf_tests branch July 15, 2025 00:06
@ekluzek ekluzek mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekluzek ekluzek ekluzek approved these changes

@wwieder wwieder Awaiting requested review from wwieder

Assignees

@slevis-lmwg slevis-lmwg

Labels

bfb bit-for-bit PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete size: small testing additions or changes to tests

Projects

CTSM: Upcoming tags
Status: Done (non release/external)

Milestone

ctsm6.0.0 (code freeze)

Development

Successfully merging this pull request may close these issues.

Remove testmods_dirs/clm/flexCN_FUN_BNF and corresponding test(s) as redundant

2 participants

@slevis-lmwg @ekluzek