Skip to content

Minor improvements to generate_gdd20_baseline.py#3727

Merged
samsrabin merged 3 commits into
ESCOMP:b4b-devfrom
samsrabin:minor-gengdd20bl-improvements
Jan 30, 2026
Merged

Minor improvements to generate_gdd20_baseline.py#3727
samsrabin merged 3 commits into
ESCOMP:b4b-devfrom
samsrabin:minor-gengdd20bl-improvements

Conversation

@samsrabin
Copy link
Copy Markdown
Member

@samsrabin samsrabin commented Jan 30, 2026

Description of changes

This PR contains two commits with changes I made during work on generate_gdd20_baseline.py.

The first commit touches many other files, because it standardizes the output netCDF format from our Python tools to be NETCDF4_CLASSIC. This is compatible with CTSM while also greatly improving write performance.

The second commit is much simpler: It makes an output directory if needed.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:
Tested as part of my crop reparameterization work.

  • Python unit testing
  • Python system testing
  • clm_pymods test suite
  • rxcropmaturity test suite

It's much better at streaming writes, which avoids the "trickling" you see sometimes when writing large files.
@samsrabin samsrabin self-assigned this Jan 30, 2026
@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability code health improving internal code structure to make easier to maintain (sustainability) b4b bit-for-bit PR status: awaiting review Work on this PR is paused while waiting for review. PR status: needs testing size: small test: python Pass clm_pymods test suite plus Python sys/unit tests before merging labels Jan 30, 2026
@samsrabin samsrabin removed the PR status: awaiting review Work on this PR is paused while waiting for review. label Jan 30, 2026
@samsrabin samsrabin merged commit eda9bfb into ESCOMP:b4b-dev Jan 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability PR status: needs testing size: small test: python Pass clm_pymods test suite plus Python sys/unit tests before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants