-
Notifications
You must be signed in to change notification settings - Fork 344
ctsm5.4.017: Introduce CRUJRA2024b datm option (Greenland snow hole filled) #3734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CISM to latest version with answer changes Update the CISM submodule to the latest tag used in cesm3_0_beta0b. This includes cismwrap_2_2_012 and cismwrap_2_2_013, both of which includes answer changes for CISM due to changes in namelist defaults. Add a new test for running both Antarctic and Greenland ice sheets. Add new compsets for CISM with Clm60.
Contributor
Author
|
Contributor
Author
|
@ekluzek these changes are ready for review. TODOs
|
Merge b4b-dev to master slevis resolved conflicts: doc/ChangeLog doc/ChangeSum
ekluzek
approved these changes
Feb 9, 2026
slevis-lmwg
added a commit
to slevis-lmwg/ctsm
that referenced
this pull request
Feb 10, 2026
Introduce CRUJRA2024b datm option (Greenland snow hole filled) - Includes corresponding changes in cdeps by updating cdeps1.0.84 to cdeps1.0.91; for consistency with cdeps, I also updated cmeps from cmeps1.1.24 to cmeps1.1.29 - Includes renaming of CRUJRA2024 files present in /python/ctsm/test/testinputs/expected_result_files to permit all tests to pass The default datm input dataset changes from CRUJRA2024 to CRUJRA2024b. The former has Antarctica filled and the latter has Greenland also filled. User may select either CRUJRA2024 or CRUJRA2024b using long compset names, e.g. HIST_DATM%CRUJRA2024_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP HIST_DATM%CRUJRA2024b_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP Answers Change: New climate over Greenland due to the new datm files; cpl output diffs due to the submodule updates listed below. Issues Fixes ESCOMP#3680 and parts of ESCOMP#3707 In cdeps this fixes ESCOMP/CDEPS#382 PRs ESCOMP#3734 ESCOMP/CDEPS#385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
new capability or improved behavior of existing capability
external
issue needs to be addressed elsewhere (submodule); issue here for the sake of project tracking
non-bfb
Changes answers (incl. adding tests)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR will follow the corresponding cdeps PR ESCOMP/CDEPS#385
Specific notes
Contributors other than yourself, if any:
@wwieder generated the new dataset, CRUJRA2024b
CTSM Issues Fixed (include github issue #):
Relates to #3707 and #3680
Are answers expected to change (and if so in what way)?
Yes, answers will change in Greenland due to the new datm files, but answers will also change as a result of the submodule updates:
cdeps1.0.84 --> cdeps1.0.88
cmeps1.1.24 --> cmeps1.1.29
Any User Interface Changes (namelist or namelist defaults changes)?
CRUJRA2024 continues to use the previous version of this data, while CRUJRA2024b picks up the new version
Does this create a need to change or add documentation? Did you do so?
I did update some doc files
Testing performed so far on derecho:
FAIL SUBSETDATAPOINT_Ld5_D_Mmpi-serial.CLM_USRDAT.I2000Clm60BgcCropCrujra.derecho_intel.clm-defaultreturns this
ERROR: /glade/derecho/scratch/slevis/tests_0202-161555de/SUBSETDATAPOINT_Ld5_D_Mmpi-serial.CLM_USRDAT.I2000Clm60BgcCropCrujra.derecho_intel.clm-default.C.0202-161555de_int/user_nl_datm_streams contains a streamname 'CLMCRUJRA2024b.Solar' that is not part of valid streamnames ['CLMCRUJRA2024.Solar', 'CLMCRUJRA2024.Precip', 'CLMCRUJRA2024.TPQW', 'presaero.clim_2000', 'presndep.clim_2000_cmip6', 'preso3.clim_2000', 'topo.observed']that I have not resolved, yet