ctsm5.4.018: Quick fix so that we can use Nitrogen Deposition sent from the ATM model #3745
+3,617
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…read internally by CTSM
…on bringing ndep from the ATM model
ekluzek
added
priority: Immediate
github-project-automation
bot
moved this to Ready to start (or start again)
in CTSM: Upcoming tags
ekluzek
moved this from Ready to start (or start again)
to In progress - master
in CTSM: Upcoming tags
ekluzek
changed the title
… the general namelist_defaults file
…eded and not getting it from the CPL, update comments around this as well
Merge b4b-dev to master
…is not quite right
4 tasks
…settings from 1850 and 20thC_transient are all in the namelist_defaults file, make sure this is all correct in the build-namelist tester
…o quick_fix_ndep_from_atm
Collaborator
Author
|
OK, started aux_clm on Derecho and Izumi. I'll work on the change files and bring this in after testing looks good. |
slevis-lmwg
requested changes
Feb 12, 2026
Contributor
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
@ekluzek thanks for this PR! I requested some minor changes. I also asked about the strange appearance of over 3000 new lines in the .rst file.
|
|
||
| build-namelist tests (if CLMBuildNamelist.pm has changed): | ||
|
|
||
| derecho - OK (some changes relative to ctsm5.4.018) |
Contributor
There was a problem hiding this comment.
Should this say instead:
Suggested change
| derecho - OK (some changes relative to ctsm5.4.018) | |
| derecho - OK (some changes relative to ctsm5.4.017) |
| @@ -292,7 +292,3409 @@ The current state of the atmosphere (:numref:`Table Atmospheric input to land mo | |||
|
|
|||
| :sup:`3`\ There are 14 aerosol deposition rates required depending on species and affinity for bonding with water; 8 of these are dust deposition rates (dry and wet rates for 4 dust size bins, :math:`D_{dst,\, dry1},\, D_{dst,\, dry2},\, D_{dst,\, dry3},\, D_{dst,\, dry4}`, :math:`D_{dst,\, \, wet1},D_{dst,\, wet2},\, D_{dst,wet3},\, D_{dst,\, wet4}` ), 3 are black carbon deposition rates (dry and wet hydrophilic and dry hydrophobic rates, :math:`D_{bc,\, dryhphil},\, D_{bc,\, wethphil},\, D_{bc,\, dryhphob}` ), and 3 are organic carbon deposition rates (dry and wet hydrophilic and dry hydrophobic rates, :math:`D_{oc,\, dryhphil},\, D_{oc,\, wethphil},\, D_{oc,\, dryhphob}` ). These fluxes are computed interactively by the atmospheric model (when prognostic aerosol representation is active) or are prescribed from a time-varying (annual cycle or transient), globally-gridded deposition file defined in the namelist (see the CLM4.5 User's Guide). Aerosol deposition rates were calculated in a transient 1850-2009 CAM simulation (at a resolution of 1.9x2.5x26L) with interactive chemistry (troposphere and stratosphere) driven by CCSM3 20\ :sup:`th` century sea-surface temperatures and emissions (:ref:`Lamarque et al. 2010<Lamarqueetal2010>`) for short-lived gases and aerosols; observed concentrations were specified for methane, N\ :sub:`2`\ O, the ozone-depleting substances (CFCs),and CO\ :sub:`2`. The fluxes are used by the snow-related parameterizations (Chapters :numref:`rst_Surface Albedos` and :numref:`rst_Snow Hydrology`). | |||
|
|
|||
| :sup:`4`\ The nitrogen deposition rate is required by the biogeochemistry model when active and represents the total deposition of mineral nitrogen onto the land surface, combining deposition of NO\ :sub:`y` and NH\ :sub:`x`. The rate is supplied either as a time-invariant spatially-varying annual mean rate or time-varying for a transient simulation. Nitrogen deposition rates were calculated from the same CAM chemistry simulation that generated the aerosol deposition rates. | |||
| :sup:`4`\ The nitrogen deposition rate is required by the biogeochemistry model when active and represents the total deposition of mineral nitrogen onto the land surface, combining deposition of NO\ :sub:`y` and NH\ :sub:`x`. The rate is supplied either as a time-varying spatially-varying monthly mean rate fixed for a particular year for control simulations or advancing yearly for transient simulation. This is for the case when CTSM reads it's own datasets, but when coupled to CAM it can also use the Nitrogen deposition calculated or read in by it. For the datasets that CTSM uses Nitrogen deposition rates were calculated from the same CAM chemistry simulation that generated the aerosol deposition rates. | |||
Contributor
There was a problem hiding this comment.
Small, potentially helpful clarifications:
Suggested change
| :sup:`4`\ The nitrogen deposition rate is required by the biogeochemistry model when active and represents the total deposition of mineral nitrogen onto the land surface, combining deposition of NO\ :sub:`y` and NH\ :sub:`x`. The rate is supplied either as a time-varying spatially-varying monthly mean rate fixed for a particular year for control simulations or advancing yearly for transient simulation. This is for the case when CTSM reads it's own datasets, but when coupled to CAM it can also use the Nitrogen deposition calculated or read in by it. For the datasets that CTSM uses Nitrogen deposition rates were calculated from the same CAM chemistry simulation that generated the aerosol deposition rates. | |
| :sup:`4`\ The nitrogen deposition rate is required by the biogeochemistry model when active and represents the total deposition of mineral nitrogen onto the land surface, combining deposition of NO\ :sub:`y` and NH\ :sub:`x`. The rate is supplied either as a time-varying spatially-varying monthly mean rate fixed for a particular year for control simulations or advancing yearly for transient simulation. This is for the case when CTSM reads it's own datasets, but when coupled to CAM it can also use the Nitrogen deposition calculated or read in by CAM. For the datasets that CTSM uses, Nitrogen deposition rates were calculated from the same CAM chemistry simulation that generated the aerosol deposition rates. |
| "Molecular weight of dry air", :math:`MW_{da}`, 28.966, kg kmol :sup:`-1` | ||
| "Dry air gas constant", :math:`R_{da}`, :math:`{R_{gas} \mathord{\left/ {\vphantom {R_{gas} MW_{da} }} \right.} MW_{da} }`, J K :sup:`-1` kg :sup:`-1` | ||
| "Molecular weight of water vapor", :math:`MW_{wv}`, 18.016, kg kmol :sup:`-1` | ||
| "Water vapor |
Contributor
There was a problem hiding this comment.
I did not read through all these other additions, but something seems wrong... Why did all these new lines (from line 296 to 3697) appear here?
github-project-automation
bot
moved this from In progress - master
to Stalled (needs review, blocked etc.)
in CTSM: Upcoming tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add the ndep_inparm namelist to drv_flds_in, so that CTSM can turn on ndep from the ATM model. Also turn on using the ndep from the ATM model for the cam LndTuningMode testmods. And make sure ndep comes from CAM when we are coupled to CAM.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? Yes (just for the cam LndTuningMode BGC tests)
Answers change to a small amount because of small differences in interpolation and
sending the data through the system as well as the difference between using NDEP_month
rather than the sum of NDEP_NOy_month+NDEP_NHx_month witn single precision data
Any User Interface Changes (namelist or namelist defaults changes)? Yes
Does this create a need to change or add documentation? Did you do so? Yes Yes
Testing performed, if any: Single cases will run aux_clm
Currently only running SMS.ne30pg3_t232.I2000Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode
with ndep_list = 'noy', 'nhx' at the end of user_nl_clm