ctsm5.4.0xx: Fix years used by generate_gdds #3749
Open
+1,094
−652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore starting processing.
samsrabin
added
non-bfb
samsrabin
force-pushed
the
update-generate_gdds-cleaner4
branch
from
22f74c2 to
fc59eca
Compare
Doesn't really matter, but just for clarity, since we expect only annual h1 files but daily h2 files.
Was redundant with _t232 version of f09 RXCROPMATURITY_ test, which is now preferred.
To satisfy pylint.
samsrabin
force-pushed
the
update-generate_gdds-cleaner4
branch
from
fc59eca to
31af968
Compare
github-project-automation
bot
moved this to Ready to start (or start again)
in CTSM: Upcoming tags
samsrabin
moved this from Ready to start (or start again)
to In progress - master
in CTSM: Upcoming tags
samsrabin
commented
Feb 11, 2026
samsrabin
commented
Feb 11, 2026
samsrabin
commented
Feb 11, 2026
samsrabin
commented
Feb 11, 2026
samsrabin
commented
Feb 12, 2026
samsrabin
commented
Feb 12, 2026
slevis-lmwg
approved these changes
Feb 12, 2026
Contributor
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
@samsrabin and I did a detailed walkthrough.
@samsrabin will resolve things that came up in the walkthrough.
samsrabin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This fixes a bug where
generate_gddswas looking for the wrong timestamps.Does not change answers in any
aux_clmtests, but does change answers from the tool and in therxcropmaturitysuite, so should go tomasterinstead ofb4b-dev.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? Yes, when using the
generate_gddstool.Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: As of 31af968:
rxcropmaturitysuiteAfter approval:
rxcropmaturitysuiteaux_clm