replaced repo/* with repo/. so it will copy all files including hidden#89
Open
dataneger wants to merge 1 commit intoEasyCorp:masterfrom
Open
replaced repo/* with repo/. so it will copy all files including hidden#89dataneger wants to merge 1 commit intoEasyCorp:masterfrom
dataneger wants to merge 1 commit intoEasyCorp:masterfrom
Conversation
Author
|
The error on continuous-integration/travis-ci/pr is caused by a composer install error not the code inside the pr that is failing. |
Author
|
For people still wanting to use hidden files. The work around i used was:
|
Author
|
I understand that you don't want to copy the .git folder to the release folder. So maybe we can just exclude that instead of all hidden files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that in the DefaultDeployer.php you copy the folder with the following command.
cp -RPp {{ deploy_dir }}/repo/* {{ project_dir }}But the wildcard (*) filemask skips hidden files starting with a dot (.gitignore, .env.test).
To do a full copy including hidden files you should use the dot instead of the wildcard
cp -RPp {{ deploy_dir }}/repo/. {{ project_dir }}This should result in a compleet copy of the repo directory into the release directory.
In my case we use .env.test .env.prod files and we wanted to copy them to .env but the files weren't copied so i got an error.
If the wildcard is intentional to prevent security issues i can understand. But in my opinion it should copy the complete directory to prevent weird behavior.