-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for generated constants in RPG:: classes #287
Conversation
Thanks! This will also be very useful for #245. |
Lets make a quick style discussion: |
From my understanding, hungarian notation is where you add a prefix or suffix to say the type. And that to me is horrible. Its useless info and when you change the type you have to change the name too. I hate it. Using "k" constant is not a C++11 thing. It just a style habit I picked up. It's not because it's german, it's because I don't much care what convention we use. We just have to pick one. |
Ah I thought it is k because c is the prefix for classes. I dislike using e for enum but for the k we did a quick poll and the result is: We don't kare |
* Adds State::kDeath * Adds pan constants so that they don't need to be duplicated in Player
Fixed the whitespace. I also redefined the panning constants as X * 256 |
Towards fixing EasyRPG/Player#1516
Also adds panning constants, so that the default pan values don't need to be duplicated between player and liblcf.