Fix: Correctly handle div tags in rtl_ltr_linter.py#12528
Open
Sayyed-Arslaan wants to merge 2 commits intoEbookFoundation:mainfrom
Open
Fix: Correctly handle div tags in rtl_ltr_linter.py#12528Sayyed-Arslaan wants to merge 2 commits intoEbookFoundation:mainfrom
Sayyed-Arslaan wants to merge 2 commits intoEbookFoundation:mainfrom
Conversation
### Summary This pull request introduces a new Python script, `scripts/alphabetical_order_linter.py`, to automatically check for alphabetical order violations within the project's Markdown lists. ### Problem The repository's contributing guidelines require all lists to be in alphabetical order. With thousands of entries, it is very difficult for maintainers to manually verify this rule for every pull request, leading to inconsistencies. ### Solution This script automates the validation process. It scans `.md` files in key directories (`books`, `courses`, `more`, `casts`) and: 1. Identifies list items and extracts their titles. 2. Compares each item with the previous one to ensure alphabetical order. 3. Reports any violations with the filename, line number, and the conflicting lines. 4. Exits with a non-zero status code if errors are found, making it ideal for integration into CI/CD workflows (like GitHub Actions). This tool will help maintain the quality of the lists and significantly reduce the manual review effort for maintainers. **How to use:** ```bash python scripts/alphabetical_order_linter.py
Removed handling for opening <div> tags with markdown attribute.
|
Oh no 😟! Conflicts have been found. Please 🙏, take a moment and address the merge conflicts of your pull request before we can evaluate it again. Thanks in advance for your effort and patience ❤️! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the
rtl_ltr_linter.pyscript where lines containing both an opening (<div>) and a closing (</div>) tag were not processed correctly.The original code used a
continuestatement after handling the opening<div>tag, which caused the script to immediately skip to the next line, ignoring the closing</div>tag on the same line. This fix removes the unnecessarycontinuestatement, allowing the linter to correctly process both tags and maintain the correct state of the block context stack.Closes #12430
Closes #12500