fix: improve error handling with HTTP utility functions #8283

badrivlog · 2023-07-20T18:12:18Z

Fixes Issue

What?

added a new util file apiRequests.js, containing functions for sending API requests.
Implemented sendRequest function that handles various types of API requests, handles rejected promise and also converts the response to JSON

Why?

abstract api request functionality into one function that we can use all over our project.
These changes improved error handling

How?

replace fetch with sendRequest in manage profile sections

Testing?

Step to test

Pull down this branch
visit localhost:3000/account/manage/profile (link, milestone, event, testimonials)
send an invalid api request by sendRequest function
see the request actually rejected and displayed the error to UI

Anything else?

Let's consider implementing it other areas of the project. I will happy to doing that work💪

Check List (Check all the applicable boxes)

My code follows the code style of this project.
My change requires changes to the documentation.
I have updated the documentation accordingly.
All new and existing tests passed.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Implemented a sendRequest utility functions to handle various types of HTTP requests, these functions provide a convenient interface for making API request and interacting with server resources.

updated: pages/account/manage/profile.js

Refactored manage profile sections of the codebase to utilize the new sendRequest utility function for making api requests.

replace fetch with sendRequest, handling error and display error to ui

badrivlog · 2023-08-07T07:04:16Z

Hey, could I have some update regarding this PR?

eddiejaoude · 2023-08-07T07:40:19Z

Hey, could I have some update regarding this PR?

Sorry for the delay, I have shared with the maintainers and I am waiting to hear their thoughts on it

pages/account/manage/event/[[...data]].js

pages/account/manage/profile.js

pages/account/manage/testimonials.js

badrivlog · 2023-08-11T03:45:12Z

@azhechkova,

I'd greatly appreciate it if you could take another look at the pull request and let me know if the changes align with your expectations. Your expertise is truly valued in ensuring the quality of the code.

Thank you for your time and consideration!

azhechkova · 2023-08-11T05:07:16Z

@badrivlog sorry for the delay, PR looks good!

badrivlog · 2023-08-11T05:59:08Z

@badrivlog sorry for the delay, PR looks good!

No problem at all! Thanks for taking the time to review👍

services/utils/apiRequests.js

lukeecart

I like the idea and left a few comments

services/utils/apiRequests.js

badrivlog · 2023-08-12T12:57:43Z

I like the idea and left a few comments

Thanks for taking the time to review👍

badrivlog · 2023-08-12T16:30:31Z

@lukeecart,

Addressed the suggested changes and made updates to the PR👍 Could you please take another look and let me know if everything aligns with your expectations? Your feedback is important to me

lukeecart

Lgtm. Nice job

badrivlog · 2023-08-15T12:36:17Z

@eddiejaoude, I believe we're now ready to proceed with merging the PR into the main codebase. Could you please take a look at the changes and, if everything looks good to you, give the final approval for merging?

eddiejaoude · 2023-08-15T16:22:24Z

@eddiejaoude, I believe we're now ready to proceed with merging the PR into the main codebase. Could you please take a look at the changes and, if everything looks good to you, give the final approval for merging?

Thank you @badrivlog for your efforts on this, but after discussing with the other maintainers, we feel it it extra abstraction that is not required, so I will close for now. Sorry for letting this go so far but I was trying to understand the benefit.

badrivlog · 2023-08-15T17:18:56Z

@eddiejaoude,Thank you🙏 for your prompt attention to my PR. I appreciate the time you took to review it and consider its potential impact. While I'm disappointed that the changes didn't align with the project's current direction, I completely understand and respect your decision💯

I'm looking forward to contributing further to the project in a way that aligns with its direction👍

eddiejaoude · 2023-08-15T19:18:42Z

Thank you for understanding @badrivlog - yes please continue contributing to LinkFree, I look forward to geeking out more 💪

badrivlog added 2 commits July 20, 2023 22:27

feat: added sendRequest utility functions for sending request

430e476

Implemented a sendRequest utility functions to handle various types of HTTP requests, these functions provide a convenient interface for making API request and interacting with server resources.

fix: replace fetch with sendRequest in manage profle

fbf2f85

updated: pages/account/manage/profile.js

Pradumnasaraf added 💻 aspect: code undefined issue linked Pull Request has issue linked labels Jul 22, 2023

badrivlog added 3 commits July 26, 2023 00:02

fix: make utility function more generic

926490e

fix: fix error message

57c03d9

fix: replace fetch with sendRequest

a2d095e

Refactored manage profile sections of the codebase to utilize the new sendRequest utility function for making api requests.

badrivlog marked this pull request as ready for review July 28, 2023 10:21

fix: replace fetch with sendRequest in testimonials

5a0cfba

replace fetch with sendRequest, handling error and display error to ui

badrivlog mentioned this pull request Aug 5, 2023

[BUG] needs proper error handling in manage form section #8112

Closed

azhechkova reviewed Aug 8, 2023

View reviewed changes

badrivlog added 5 commits August 9, 2023 21:24

merge branch main into issue-8112

7188edd

fix: add default headers for sendRequest

a556682

fix: get BASE_URL from config

373c943

fix: moved formating error into formatErrorMsg function

6c377cb

refactor: refactored some duplicate logic in testimonials

8f59a5a

badrivlog requested a review from azhechkova August 9, 2023 18:11

azhechkova approved these changes Aug 11, 2023

View reviewed changes

badrivlog added 2 commits August 11, 2023 13:27

refactor: refactored formatErrorMsg function

fa8694b

merge branch 'main' into 'issue-8112'

e6b0fc2

lukeecart reviewed Aug 12, 2023

View reviewed changes

services/utils/apiRequests.js Outdated Show resolved Hide resolved

lukeecart reviewed Aug 12, 2023

View reviewed changes

services/utils/apiRequests.js Outdated Show resolved Hide resolved

lukeecart reviewed Aug 12, 2023

View reviewed changes

services/utils/apiRequests.js Outdated Show resolved Hide resolved

fix: add mapper function for generating request options

f06fc4e

refactor: refactor formatErrorMsg function

ad03bd7

lukeecart approved these changes Aug 12, 2023

View reviewed changes

badrivlog added 2 commits August 13, 2023 23:41

fix: make mapper function pure

3f8d62f

merge branch 'main' into 'issue-8112'

22d382f

eddiejaoude closed this Aug 15, 2023

badrivlog deleted the issue-8112 branch August 15, 2023 17:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve error handling with HTTP utility functions #8283

fix: improve error handling with HTTP utility functions #8283

badrivlog commented Jul 20, 2023 •

edited

Loading

badrivlog commented Aug 7, 2023

eddiejaoude commented Aug 7, 2023

badrivlog commented Aug 11, 2023

azhechkova commented Aug 11, 2023

badrivlog commented Aug 11, 2023 •

edited

Loading

lukeecart left a comment

badrivlog commented Aug 12, 2023

badrivlog commented Aug 12, 2023

lukeecart left a comment •

edited

Loading

badrivlog commented Aug 15, 2023

eddiejaoude commented Aug 15, 2023

badrivlog commented Aug 15, 2023

eddiejaoude commented Aug 15, 2023

fix: improve error handling with HTTP utility functions #8283

fix: improve error handling with HTTP utility functions #8283

Conversation

badrivlog commented Jul 20, 2023 • edited Loading

Fixes Issue

What?

Why?

How?

Testing?

Anything else?

Check List (Check all the applicable boxes)

Screenshots

Note to reviewers

badrivlog commented Aug 7, 2023

eddiejaoude commented Aug 7, 2023

badrivlog commented Aug 11, 2023

azhechkova commented Aug 11, 2023

badrivlog commented Aug 11, 2023 • edited Loading

lukeecart left a comment

Choose a reason for hiding this comment

badrivlog commented Aug 12, 2023

badrivlog commented Aug 12, 2023

lukeecart left a comment • edited Loading

Choose a reason for hiding this comment

badrivlog commented Aug 15, 2023

eddiejaoude commented Aug 15, 2023

badrivlog commented Aug 15, 2023

eddiejaoude commented Aug 15, 2023

badrivlog commented Jul 20, 2023 •

edited

Loading

badrivlog commented Aug 11, 2023 •

edited

Loading

lukeecart left a comment •

edited

Loading