Replacing NSURLConnection with NSURLSession #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSURLConnection is caching for all subsequent calls and cert pinning call is always returning CONNECTION_SECURE irrespective of what. It's not working even if we disable caching. So replacing NSURLConnection with NSURLSession.
|
Hi! I'd love to merge this but don't have time to test atm. Is anyone else able to test this PR perhaps? |
|
@EddyVerbruggen : FYI, we deployed my changes to PROD app 2 weeks back. So far we didn't have any issues. |
|
That's good to know, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSURLConnection is caching for all subsequent calls and cert pinning call is always returning CONNECTION_SECURE irrespective of what. It's not working even if we disable caching. So replacing NSURLConnection with NSURLSession.