Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/orcid #61

Merged
merged 9 commits into from
Feb 11, 2025
Merged

Feature/orcid #61

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2871217
add orcids
anneferger Feb 10, 2025
44f40b9
Merge remote-tracking branch 'origin/main'
anneferger Feb 10, 2025
a3c5432
display orcids and display email first
anneferger Feb 10, 2025
485eda8
added ordcids from nfdi4c website
anneferger Feb 10, 2025
b8bd312
added Silke to vife-website
anneferger Feb 10, 2025
a052781
update email for tobias
anneferger Feb 10, 2025
3bb4282
revert removing previous project
anneferger Feb 11, 2025
bfb7057
center orcid icon correctly
anneferger Feb 11, 2025
c9889e2
adjust styling of orcid icon
peterstadler Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions _data/team.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
- name: Martin Albrecht-Hohmaier
sortkey: Albrecht-Hohmaier
orcid: 0000-0002-5279-7408
email: [email protected]
affiliation:
- nfdi
Expand Down Expand Up @@ -27,6 +28,7 @@
- name: Daniel Röwenstrunk
sortkey: Röwenstrunk
email: [email protected]
orcid: 0000-0001-6271-2095
affiliation:
- edirom
- freidi
Expand All @@ -38,6 +40,7 @@
- name: Katharina Bergmann
sortkey: Bergmann
email: [email protected]
orcid: 0000-0002-0758-9917
affiliation:
- nfdi
image: /assets/img/team_katharina.jpg
Expand Down Expand Up @@ -102,6 +105,7 @@
phone: +49 5231 975–669
- name: Kristina Richts-Matthaei
sortkey: Richts
orcid: 0000-0001-8569-1995
email: [email protected]
affiliation:
- mei
Expand All @@ -111,6 +115,7 @@
phone: +49 5231 975–665
- name: Andreas Münzmay
sortkey: Münzmay
orcid: 0000-0002-8373-4055
email: [email protected]
affiliation:
- zenmem
Expand All @@ -121,6 +126,7 @@
phone: +49 5231 975–672
- name: Anastasia Wawilow
sortkey: Wawiliow
orcid: 0000-0003-2840-128X
email: [email protected]
affiliation:
- zenmem
Expand All @@ -145,12 +151,14 @@
image: /assets/img/team_agnes.jpeg
- name: Anne Ferger
sortkey: Ferger
orcid: 0000-0002-1382-2658
email: [email protected]
affiliation:
- nfdi
image: /assets/img/team_anne.jpg
- name: Daniel Jettka
sortkey: Jettka
orcid: 0000-0002-2375-2227
email: [email protected]
affiliation:
- nfdi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually we keep the former affiliations. Of course if @daniel-jettka wants this removed please remove it

Expand Down Expand Up @@ -217,6 +225,7 @@
image: /assets/img/team_dunja.jpg
- name: Tobias Bachmann
sortkey: Bachmann
email: [email protected]
image: /assets/img/team_tobias.jpg
affiliation:
- openedirom
Expand All @@ -240,3 +249,7 @@
image: assets/img/team_lisa.jpg
affiliation:
- tamudi
- name: Silke Reich
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we ask her for an image? Otherwise she'll be the only one without …

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silke will add an image next week

sortkey: Reich
affiliation:
- korngold
11 changes: 11 additions & 0 deletions _sass/main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,3 +160,14 @@ figure {
font-style: italic;
}
}

.orcid_icon {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new Orcid icon is a little bit misplaced to the top (tested and screenshotted with Firefox on Mac).
Bildschirmfoto 2025-02-11 um 07 59 10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you recheck with the newest version?

background-image: url('/assets/img/ORCID-iD_icon_unauth_BW_vector.svg');
background-size: 18px 18px;
width: 18px;
height: 18px;
text-align: center;
vertical-align: middle;
margin-top: 10px;
margin-bottom: 10px;
}
5 changes: 5 additions & 0 deletions assets/img/ORCID-iD_icon_unauth_BW_vector.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 7 additions & 3 deletions team.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,17 @@
<div class="card-body">
<h3 class="card-title">{{ member.name }}</h3>
<p class="card-text">
{% if member.email %}
<i class="vife_contact_icon fa fa-envelope"></i>
<span>{{ member.email }}</span><br />
{% endif %}
{% if member.phone %}
<i class="vife_contact_icon fa fa-phone"></i>
<a href="tel:{{ member.phone }}">{{ member.phone }}</a><br />
{% endif %}
{% if member.email %}
<i class="vife_contact_icon fa fa-envelope"></i>
<span>{{ member.email }}</span><br />
{% if member.orcid %}
<i class="vife_contact_icon fa orcid_icon"></i>
<a href="https://orcid.org/{{ member.orcid }}">{{ member.orcid }}</a><br />
{% endif %}
{% if member.affiliation %}
<i class="vife_contact_icon fa fa-globe"></i>
Expand Down