fix(CheckBox): correct disabled focus-visible selector and add allowDisabledFocus story#1123
Closed
ykelkar-eightfold wants to merge 19 commits intoEightfoldAI:mainfrom
Closed
fix(CheckBox): correct disabled focus-visible selector and add allowDisabledFocus story#1123ykelkar-eightfold wants to merge 19 commits intoEightfoldAI:mainfrom
ykelkar-eightfold wants to merge 19 commits intoEightfoldAI:mainfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
.selector.disabledblock:input→input[disabled]to prevent erroneously suppressing focus rings on non-disabled checkboxes inside a
disabled wrapper
Check_Box_Allow_Disabled_FocusStorybook story demonstratingallowDisabledFocusprop behavior on disabled checkboxes
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-191073
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
.disabledwrapper — confirm focus ring issuppressed (outline: none) only on the disabled input, not sibling enabled inputs
Check_Box_Allow_Disabled_Focusstory renders both variants correctly inStorybook