Accessibility fix for Select and Dropdown components #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
==========================================
- Coverage 84.66% 84.61% -0.05%
==========================================
Files 1099 1100 +1
Lines 20416 20489 +73
Branches 7718 7749 +31
==========================================
+ Hits 17285 17337 +52
- Misses 3044 3065 +21
Partials 87 87 ☔ View full report in Codecov by Sentry. |
| @@ -915,6 +916,7 @@ export const Select: FC<SelectProps> = React.forwardRef( | |||
| shape={selectShapeToTextInputShapeMap.get(mergedShape)} | |||
| size={selectSizeToTextInputSizeMap.get(mergedSize)} | |||
| value={selectedOptionText} | |||
| clearButtonAriaLabel={clearButtonAriaLabel} | |||
There was a problem hiding this comment.
this should be inside clear props
There was a problem hiding this comment.
I don't see any such prop on clear button? Am I missing something @sravichandran-eightfold
abhishek-yadav-eightfold
changed the title
…bhishek/ENG-120354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Updating aria-label attribute for the clear text button to make the element accessible.
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-120354
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN: