fix: improved accessibility of dropdown #954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
==========================================
+ Coverage 84.44% 84.45% +0.01%
==========================================
Files 1103 1104 +1
Lines 20557 20643 +86
Branches 7779 7817 +38
==========================================
+ Hits 17359 17434 +75
- Misses 3110 3121 +11
Partials 88 88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ypatadia-eightfold
force-pushed
the
ypatadia/ENG-132612/dropdown-accessibility-changes
branch
from
786522a to
8fc8a62
Compare
| }; | ||
| // If clicking on an element inside a list item and closeOnElementClick is false, | ||
| // don't close the dropdown | ||
| if (!closeOnElementClick && isElementInsideListItem(event.target)) { |
There was a problem hiding this comment.
you might need to check multiple as well.. If you have multi selection, then the close on element click might not help
ypatadia-eightfold
force-pushed
the
ypatadia/ENG-132612/dropdown-accessibility-changes
branch
from
16a7f3d to
835cd10
Compare
…opdown-accessibility-changes fix: merge
sravichandran-eightfold
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
change button to div (like radix UI)
tab to focus dropdown
enter to open dropdown
up/down/left/right key to navigate items inside dropdown
enter to select focused item of dropdown
esc/tab to close dropdown
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-132612
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN: