Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new package to evaluate against a number of different datasets #93

Merged
merged 12 commits into from
Oct 30, 2024
Merged

Add new package to evaluate against a number of different datasets #93

merged 12 commits into from
Oct 30, 2024

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Aug 9, 2024 •
edited
Loading

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Additional comments

Anything worth mentioning to the reviewers.

@glpuga glpuga force-pushed the glpuga/dataset_running_toolset branch 3 times, most recently from 74a43fb to 69df832 Compare August 16, 2024 15:47
@glpuga glpuga force-pushed the glpuga/dataset_running_toolset branch 5 times, most recently from 7b2e8f4 to 54adfb3 Compare August 27, 2024 20:00
hidmic
hidmic reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, awesome work @glpuga !

...2_multi_dataset/reports/nominal_report/sections/datasets/diff_drive_sim_24hs_description.inc Outdated Show resolved Hide resolved
...2_multi_dataset/reports/nominal_report/sections/datasets/diff_drive_sim_24hs_description.inc Outdated Show resolved Hide resolved
...av2_multi_dataset/reports/nominal_report/sections/datasets/magazino_datasets_description.inc Outdated Show resolved Hide resolved
...2_multi_dataset/reports/nominal_report/sections/datasets/omni_drive_sim_24hs_description.inc Outdated Show resolved Hide resolved
...2_multi_dataset/reports/nominal_report/sections/datasets/omni_drive_sim_24hs_description.inc Outdated Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/main_corpus.inc.bkp Outdated Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/platform.inc Outdated Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/scripts/nominal.robot Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/main_corpus.inc Outdated Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/main_corpus.inc Show resolved Hide resolved
@glpuga glpuga force-pushed the glpuga/dataset_running_toolset branch 3 times, most recently from b0cbf6f to 11ac641 Compare October 16, 2024 14:18
@glpuga glpuga force-pushed the glpuga/dataset_running_toolset branch from 11ac641 to df7f70c Compare October 21, 2024 20:27
This was referenced Oct 24, 2024
Closed
Closed
@glpuga glpuga mentioned this pull request Oct 28, 2024
Open
@hidmic hidmic mentioned this pull request Oct 28, 2024
Open
@glpuga glpuga force-pushed the glpuga/dataset_running_toolset branch from df7f70c to 9b0ae09 Compare October 29, 2024 20:03
@glpuga glpuga marked this pull request as ready for review October 29, 2024 20:03
@glpuga glpuga requested a review from nahueespinosa as a code owner October 29, 2024 20:03
@glpuga glpuga force-pushed the glpuga/dataset_running_toolset branch from 9b0ae09 to f6e2320 Compare October 29, 2024 21:21
hidmic
hidmic previously approved these changes Oct 29, 2024
View reviewed changes
src/benchmarks/beluga_vs_nav2_multi_dataset/Earthfile Outdated Show resolved Hide resolved
...2_multi_dataset/reports/nominal_report/sections/datasets/diff_drive_sim_24hs_description.inc Outdated Show resolved Hide resolved
...2_multi_dataset/reports/nominal_report/sections/datasets/diff_drive_sim_24hs_description.inc Outdated Show resolved Hide resolved
...av2_multi_dataset/reports/nominal_report/sections/datasets/magazino_datasets_description.inc Outdated Show resolved Hide resolved
...2_multi_dataset/reports/nominal_report/sections/datasets/omni_drive_sim_24hs_description.inc Outdated Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/main_corpus.inc Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/platform.inc Outdated Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/platform.inc Outdated Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/platform.inc Outdated Show resolved Hide resolved
src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_report/sections/platform.inc Outdated Show resolved Hide resolved
glpuga and others added 7 commits October 30, 2024 10:15
@glpuga
Add new package to evaluate against a number of different datasets
68f3b11 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga @hidmic
Update src/benchmarks/beluga_vs_nav2_multi_dataset/reports/nominal_re…
56b8e2a 
…port/sections/datasets/diff_drive_sim_24hs_description.inc

Co-authored-by: Michel Hidalgo <[email protected]>
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga
Fix function rounding digits
0fd1b85 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga
Fix cpu/rss data capture
9336f00 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga
Fix wrong dataset names
e42256c 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga
Minor format fixes to robot file
287362b 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga
Change the order of presentation of datasets
e279119 
Signed-off-by: Gerardo Puga <[email protected]>
glpuga added 4 commits October 30, 2024 10:16
@glpuga
Add links to kobuki and rplidar specs
9d4442a 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga
Fix table header
1b8e43a 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga
Minor fix to earthfile
2613269 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga
New round of reviews
2e86572 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga glpuga force-pushed the glpuga/dataset_running_toolset branch from 4c0efab to 2e86572 Compare October 30, 2024 13:16
@glpuga
Add FastRTPS profile file
fc23f02 
Signed-off-by: Gerardo Puga <[email protected]>
@glpuga glpuga mentioned this pull request Oct 30, 2024
Open
@glpuga glpuga merged commit b040703 into main Oct 30, 2024
1 check passed
@glpuga glpuga deleted the glpuga/dataset_running_toolset branch October 30, 2024 15:27
@hidmic hidmic mentioned this pull request Feb 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@nahueespinosa nahueespinosa Awaiting requested review from nahueespinosa nahueespinosa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glpuga @hidmic