Skip to content

Commit

Permalink
detekt fix8
Browse files Browse the repository at this point in the history
  • Loading branch information
@Logomann
Logomann committed Aug 21, 2024
1 parent 568f04d commit b4a8d00
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 25 deletions.
8 changes: 2 additions & 6 deletions app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterCountryFragment.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,12 @@ import ru.practicum.android.diploma.databinding.FragmentSelectCountryBinding
import ru.practicum.android.diploma.domain.models.Country
import ru.practicum.android.diploma.presentation.viewmodels.FilterCountryViewModel
import ru.practicum.android.diploma.ui.state.CountriesScreenState
import ru.practicum.android.diploma.util.COUNTRY_BUNDLE_KEY
import ru.practicum.android.diploma.util.COUNTRY_REQUEST_KEY
import ru.practicum.android.diploma.util.ResponseData
import ru.practicum.android.diploma.util.adapter.country.CountryAdapter

class FilterCountryFragment : Fragment() {

companion object {
const val COUNTRY_REQUEST_KEY = "COUNTRY_REQUEST_KEY"
const val COUNTRY_BUNDLE_KEY = "COUNTRY_BUNDLE_KEY"
}

private val binding: FragmentSelectCountryBinding by viewBinding(CreateMethod.INFLATE)
private val viewModel by viewModel<FilterCountryViewModel>()

Expand Down
12 changes: 5 additions & 7 deletions app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterFragment.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,16 @@ import ru.practicum.android.diploma.presentation.viewmodels.FilterViewModel
import ru.practicum.android.diploma.ui.fragments.FilterIndustryFragment.Companion.INDUSTRY_ITEM_KEY
import ru.practicum.android.diploma.ui.fragments.FilterIndustryFragment.Companion.INDUSTRY_KEY
import ru.practicum.android.diploma.ui.state.FilterScreenState
import ru.practicum.android.diploma.util.FILTER_BUNDLE_KEY
import ru.practicum.android.diploma.util.FILTER_REQUEST_KEY
import ru.practicum.android.diploma.util.FILTER_TO_PLACE_OF_WORK_COUNTRY_KEY
import ru.practicum.android.diploma.util.FILTER_TO_PLACE_OF_WORK_KEY
import ru.practicum.android.diploma.util.FILTER_TO_PLACE_OF_WORK_REGION_KEY
import ru.practicum.android.diploma.util.PLACE_OF_WORK_COUNTRY_KEY
import ru.practicum.android.diploma.util.PLACE_OF_WORK_KEY
import ru.practicum.android.diploma.util.PLACE_OF_WORK_REGION_KEY

class FilterFragment : Fragment() {
companion object {
const val FILTER_REQUEST_KEY = "FILTER_REQUEST_KEY"
const val FILTER_BUNDLE_KEY = "FILTER_BUNDLE_KEY"
const val FILTER_TO_PLACE_OF_WORK_KEY = "FILTER_TO_PLACE_OF_WORK_KEY"
const val FILTER_TO_PLACE_OF_WORK_COUNTRY_KEY = "FILTER_TO_PLACE_OF_WORK_COUNTRY_KEY"
const val FILTER_TO_PLACE_OF_WORK_REGION_KEY = "FILTER_TO_PLACE_OF_WORK_REGION_KEY"
}
private val binding: FragmentFilterBinding by viewBinding(CreateMethod.INFLATE)
private val viewModel by viewModel<FilterViewModel>()

Expand Down
14 changes: 7 additions & 7 deletions app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterPlaceOfWorkFragment.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@ import ru.practicum.android.diploma.databinding.FragmentSelectPlaceOfWorkBinding
import ru.practicum.android.diploma.domain.models.Country
import ru.practicum.android.diploma.domain.models.Region
import ru.practicum.android.diploma.presentation.viewmodels.FilterPlaceOfWorkViewModel
import ru.practicum.android.diploma.ui.fragments.FilterCountryFragment.Companion.COUNTRY_BUNDLE_KEY
import ru.practicum.android.diploma.ui.fragments.FilterCountryFragment.Companion.COUNTRY_REQUEST_KEY
import ru.practicum.android.diploma.ui.fragments.FilterFragment.Companion.FILTER_TO_PLACE_OF_WORK_COUNTRY_KEY
import ru.practicum.android.diploma.ui.fragments.FilterFragment.Companion.FILTER_TO_PLACE_OF_WORK_KEY
import ru.practicum.android.diploma.ui.fragments.FilterFragment.Companion.FILTER_TO_PLACE_OF_WORK_REGION_KEY
import ru.practicum.android.diploma.ui.fragments.FilterRegionFragment.Companion.REGION_BUNDLE_KEY
import ru.practicum.android.diploma.ui.fragments.FilterRegionFragment.Companion.REGION_REQUEST_KEY
import ru.practicum.android.diploma.ui.state.PlaceOfWorkScreenState
import ru.practicum.android.diploma.util.COUNTRY_BUNDLE_KEY
import ru.practicum.android.diploma.util.COUNTRY_REQUEST_KEY
import ru.practicum.android.diploma.util.FILTER_TO_PLACE_OF_WORK_COUNTRY_KEY
import ru.practicum.android.diploma.util.FILTER_TO_PLACE_OF_WORK_KEY
import ru.practicum.android.diploma.util.FILTER_TO_PLACE_OF_WORK_REGION_KEY
import ru.practicum.android.diploma.util.PLACE_OF_WORK_COUNTRY_KEY
import ru.practicum.android.diploma.util.PLACE_OF_WORK_KEY
import ru.practicum.android.diploma.util.PLACE_OF_WORK_REGION_KEY
import ru.practicum.android.diploma.util.REGION_BUNDLE_KEY
import ru.practicum.android.diploma.util.REGION_ID_KEY
import ru.practicum.android.diploma.util.REGION_REQUEST_KEY

class FilterPlaceOfWorkFragment : Fragment() {

Check warning on line 39 in app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterPlaceOfWorkFragment.kt

View workflow job for this annotation

GitHub Actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterPlaceOfWorkFragment.kt#L39 <detekt.LargeClass> 

Class FilterPlaceOfWorkFragment is too large. Consider splitting it into smaller pieces.
Raw output 
/home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterPlaceOfWorkFragment.kt:39:7: warning: Class FilterPlaceOfWorkFragment is too large. Consider splitting it into smaller pieces. (detekt.LargeClass)
private val binding: FragmentSelectPlaceOfWorkBinding by viewBinding(CreateMethod.INFLATE)
Expand Down
7 changes: 2 additions & 5 deletions app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterRegionFragment.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,12 @@ import ru.practicum.android.diploma.domain.models.Region
import ru.practicum.android.diploma.presentation.viewmodels.FilterRegionViewModel
import ru.practicum.android.diploma.ui.state.RegionsScreenState
import ru.practicum.android.diploma.util.App.Companion.REGION_ID_KEY
import ru.practicum.android.diploma.util.REGION_BUNDLE_KEY
import ru.practicum.android.diploma.util.REGION_REQUEST_KEY
import ru.practicum.android.diploma.util.ResponseData
import ru.practicum.android.diploma.util.adapter.region.RegionAdapter

class FilterRegionFragment : Fragment() {
companion object {
const val REGION_REQUEST_KEY = "REGION_REQUEST_KEY"
const val REGION_BUNDLE_KEY = "REGION_BUNDLE_KEY"
}

private val binding: FragmentSelectRegionBinding by viewBinding(CreateMethod.INFLATE)
private val viewModel by viewModel<FilterRegionViewModel>()
private val adapter = RegionAdapter {
Expand Down
9 changes: 9 additions & 0 deletions app/src/main/java/ru/practicum/android/diploma/util/Constants.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,13 @@ const val REGION_ID_KEY = "REGION_ID_KEY"
const val PLACE_OF_WORK_KEY = "PLACE_OF_WORK_KEY"
const val PLACE_OF_WORK_COUNTRY_KEY = "PLACE_OF_WORK_COUNTRY_KEY"
const val PLACE_OF_WORK_REGION_KEY = "PLACE_OF_WORK_REGION_KEY"
const val COUNTRY_REQUEST_KEY = "COUNTRY_REQUEST_KEY"
const val COUNTRY_BUNDLE_KEY = "COUNTRY_BUNDLE_KEY"
const val FILTER_REQUEST_KEY = "FILTER_REQUEST_KEY"
const val FILTER_BUNDLE_KEY = "FILTER_BUNDLE_KEY"
const val FILTER_TO_PLACE_OF_WORK_KEY = "FILTER_TO_PLACE_OF_WORK_KEY"
const val FILTER_TO_PLACE_OF_WORK_COUNTRY_KEY = "FILTER_TO_PLACE_OF_WORK_COUNTRY_KEY"
const val FILTER_TO_PLACE_OF_WORK_REGION_KEY = "FILTER_TO_PLACE_OF_WORK_REGION_KEY"
const val REGION_REQUEST_KEY = "REGION_REQUEST_KEY"
const val REGION_BUNDLE_KEY = "REGION_BUNDLE_KEY"

0 comments on commit b4a8d00

Please sign in to comment.