Добавлен Shared Prefs #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElchinGasymov
requested changes
Aug 19, 2024
| val noCurrency: Boolean? | ||
| ) : Serializable { | ||
| companion object { | ||
| private const val serialVersionUID = 1L |
There was a problem hiding this comment.
Это что за поле такое? Оно точно нужно?
| private val networkClient: NetworkClient | ||
| private val networkClient: NetworkClient, | ||
| private val sharedPreferences: SharedPreferences, | ||
| private val gson: Gson |
There was a problem hiding this comment.
В дата модуле нет дефиниции factory { Gson() }
| @@ -24,6 +24,8 @@ val interactorModule = module { | |||
| } | |||
|
|
|||
| factory<FilterInteractor> { | |||
| FilterInteractorImpl(repository = get()) | |||
| FilterInteractorImpl( | |||
| repository = get(), | |||
There was a problem hiding this comment.
Давай все будет в едином стиле как и выше, убери плиз ненужный перенос строки
There was a problem hiding this comment.
Или тут кодстайл ругается?
| FilterRepositoryImpl(networkClient = get()) | ||
| FilterRepositoryImpl( | ||
| networkClient = get(), | ||
| gson = provideGson(), |
There was a problem hiding this comment.
А что за метод такой provideGson? Может лучше сделать get(), при этом объявив gson в дата модуле как я писал выше?
G-dev-ui
approved these changes
Aug 19, 2024
Logomann
approved these changes
Aug 19, 2024
ElchinGasymov
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлен Shared Prefs