-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Граф нафигации и основные экраны #19
Граф нафигации и основные экраны #19
Conversation
Добавлен фрагмент "Вакансия" экрана описания вакансии
Исправлена ошибка в layout vacancy_fragment
# Conflicts: # gradle/libs.versions.toml
container: ViewGroup?, | ||
savedInstanceState: Bundle? | ||
): View { | ||
return inflater.inflate(R.layout.fragment_favourites, container, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
super.onViewCreated(view, savedInstanceState) | ||
|
||
view.findViewById<Button>(R.id.button_back_to_search_from_filter).setOnClickListener { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Аналогично + в остальных fragment
@@ -4,16 +4,18 @@ | |||
xmlns:tools="http://schemas.android.com/tools" | |||
android:layout_width="match_parent" | |||
android:layout_height="match_parent" | |||
tools:context=".ui.root.RootActivity"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем убрал эту строчку?
@@ -4,16 +4,18 @@ | |||
xmlns:tools="http://schemas.android.com/tools" | |||
android:layout_width="match_parent" | |||
android:layout_height="match_parent" | |||
tools:context=".ui.root.RootActivity"> | |||
android:orientation="vertical"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
android:orientation="vertical"> | |
android:orientation="vertical"> |
Эта строчка точно нужна?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
в ConstraintLayout нет
Уберу
app:navGraph="@navigation/main_navigation_graph" | ||
app:defaultNavHost="true" | ||
android:name="androidx.navigation.fragment.NavHostFragment" | ||
tools:ignore="MissingConstraints" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай вместо tools:ignore="MissingConstraints" все таки укажем нужные констрэйнты, например левый, верхний, правый - parent
@@ -0,0 +1,25 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Может лучше все описывать не на LinearLayout а на ConstraintLayout? Давай обсудим в телеге
android:label="fragment_vacancy" | ||
tools:layout="@layout/fragment_vacancy" /> | ||
<fragment | ||
android:id="@+id/team_screen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
android:id="@+id/team_screen" | |
android:id="@+id/teamFragment" |
app:destination="@id/vacancyFragment" /> | ||
</fragment> | ||
<fragment | ||
android:id="@+id/favorite_screen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
android:id="@+id/favorite_screen" | |
android:id="@+id/favoriteFragment" |
app:startDestination="@id/main_screen"> | ||
|
||
<fragment | ||
android:id="@+id/main_screen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
android:id="@+id/main_screen" | |
android:id="@+id/mainFragment" |
No description provided.