PR checks

Career hub filter industry #246

Sign in to view logs

GitHub Actions / "detekt" failed Aug 19, 2024 in 1s

reviewdog ["detekt"] report

reported by reviewdog 🐶

Findings (12)

app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|32 col 57| This empty block of code can be removed.
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|36 col 34| This empty block of code can be removed.
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|32 col 57| Missing spacing before "{"
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|36 col 34| Missing spacing before "{"
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|33 col 1| First line in a method block should not be empty
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|37 col 1| First line in a method block should not be empty
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|37 col 1| Trailing space(s)
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|32 col 17| Private function writeSharedPrefs is unused.
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|36 col 17| Private function readSharedPrefs is unused.
app/src/main/java/ru/practicum/android/diploma/di/ViewModelModule.kt|39 col 14| Unexpected spacing before "<"
app/src/main/java/ru/practicum/android/diploma/di/ViewModelModule.kt|39 col 40| Missing spacing before "{"
app/src/main/java/ru/practicum/android/diploma/util/adapter/industry/IndustryViewHolder.kt|10 col 4| Missing spacing after ":"

Filtered Findings (13)

app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterFragment.kt|46 col 18| The function onViewCreated is too long (43). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/ui/fragments/SearchFragment.kt|52 col 18| The function onViewCreated is too long (103). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/ui/fragments/SearchFragment.kt|52 col 18| The function onViewCreated appears to be too complex based on Cyclomatic Complexity (complexity: 18). Defined complexity threshold for methods is set to '10'
app/src/main/java/ru/practicum/android/diploma/ui/fragments/SearchFragment.kt|52 col 18| The function onViewCreated appears to be too complex based on Cognitive Complexity (complexity: 22). Defined complexity threshold for methods is set to '15'
app/src/main/java/ru/practicum/android/diploma/ui/fragments/VacancyFragment.kt|40 col 18| The function onViewCreated is too long (50). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/ui/fragments/VacancyFragment.kt|40 col 18| The function onViewCreated appears to be too complex based on Cyclomatic Complexity (complexity: 11). Defined complexity threshold for methods is set to '10'
app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterPlaceOfWorkFragment.kt|58 col 18| The function onViewCreated is too long (54). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterPlaceOfWorkFragment.kt|49 col 1| Needless blank line(s)
app/src/main/java/ru/practicum/android/diploma/ui/fragments/FilterRegionFragment.kt|49 col 18| The function onViewCreated is too long (46). The maximum length is 40.
app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt|41 col 1| Needless blank line(s)
app/src/main/java/ru/practicum/android/diploma/data/dto/Converters.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig
app/src/main/java/ru/practicum/android/diploma/data/network/RetrofitNetworkClient.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig
app/src/main/java/ru/practicum/android/diploma/data/db/AppDatabase.kt|3 col 1| Imports must be ordered according to the pattern specified in .editorconfig

Annotations

Check warning on line 32 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L32 <detekt.EmptyFunctionBlock>

This empty block of code can be removed.

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:32:57: warning: This empty block of code can be removed. (detekt.EmptyFunctionBlock)

Check warning on line 36 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L36 <detekt.EmptyFunctionBlock>

This empty block of code can be removed.

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:36:34: warning: This empty block of code can be removed. (detekt.EmptyFunctionBlock)

Check warning on line 32 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L32 <detekt.SpacingAroundCurly>

Missing spacing before "{"

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:32:57: warning: Missing spacing before "{" (detekt.SpacingAroundCurly)

Check warning on line 36 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L36 <detekt.SpacingAroundCurly>

Missing spacing before "{"

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:36:34: warning: Missing spacing before "{" (detekt.SpacingAroundCurly)

Check warning on line 33 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L33 <detekt.NoEmptyFirstLineInMethodBlock>

First line in a method block should not be empty

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:33:1: warning: First line in a method block should not be empty (detekt.NoEmptyFirstLineInMethodBlock)

Check warning on line 37 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L37 <detekt.NoEmptyFirstLineInMethodBlock>

First line in a method block should not be empty

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:37:1: warning: First line in a method block should not be empty (detekt.NoEmptyFirstLineInMethodBlock)

Check warning on line 37 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L37 <detekt.NoTrailingSpaces>

Trailing space(s)

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:37:1: warning: Trailing space(s) (detekt.NoTrailingSpaces)

Check warning on line 32 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L32 <detekt.UnusedPrivateMember>

Private function `writeSharedPrefs` is unused.

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:32:17: warning: Private function `writeSharedPrefs` is unused. (detekt.UnusedPrivateMember)

Check warning on line 36 in app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt#L36 <detekt.UnusedPrivateMember>

Private function `readSharedPrefs` is unused.

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/presentation/viewmodels/FilterIndustryViewModel.kt:36:17: warning: Private function `readSharedPrefs` is unused. (detekt.UnusedPrivateMember)

Check warning on line 39 in app/src/main/java/ru/practicum/android/diploma/di/ViewModelModule.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/di/ViewModelModule.kt#L39 <detekt.SpacingAroundAngleBrackets>

Unexpected spacing before "<"

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/di/ViewModelModule.kt:39:14: warning: Unexpected spacing before "<" (detekt.SpacingAroundAngleBrackets)

Check warning on line 39 in app/src/main/java/ru/practicum/android/diploma/di/ViewModelModule.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/di/ViewModelModule.kt#L39 <detekt.SpacingAroundCurly>

Missing spacing before "{"

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/di/ViewModelModule.kt:39:40: warning: Missing spacing before "{" (detekt.SpacingAroundCurly)

Check warning on line 10 in app/src/main/java/ru/practicum/android/diploma/util/adapter/industry/IndustryViewHolder.kt

github-actions / "detekt"

["detekt"] app/src/main/java/ru/practicum/android/diploma/util/adapter/industry/IndustryViewHolder.kt#L10 <detekt.SpacingAroundColon>

Missing spacing after ":"

Raw output


            /home/runner/work/practicum-android-diploma/practicum-android-diploma/app/src/main/java/ru/practicum/android/diploma/util/adapter/industry/IndustryViewHolder.kt:10:4: warning: Missing spacing after ":" (detekt.SpacingAroundColon)

View more details on GitHub Actions