Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,25 +267,25 @@ $element = $session->element(PHPWebDriver_WebDriverBy::ID, $value);

* To configure implicit waits (in seconds)

$this->$session->implicitlyWait(3);
$this->session->implicitlyWait(3);

* To disable implicit waits

$this->$session->implicitlyWait(0);
$this->session->implicitlyWait(0);

* How long to wait for an execute or execute_async to (in seconds)

$this->$session->setScriptTimeout(3);
$this->session->setScriptTimeout(3);

* How long to wait page loads to complete (in seconds)

$this->$session->setPageLoadTimeout(3);
$this->session->setPageLoadTimeout(3);

* How to set the above timeouts directly. Don't do this unless you really need ms granularity

$this->$session->setTimeouts(array('type' => 'implicit', 'ms' => 5));
$this->$session->setTimeouts(array('type' => 'script', 'ms' => 5));
$this->$session->setTimeouts(array('type' => 'page load', 'ms' => 5));
$this->session->setTimeouts(array('type' => 'implicit', 'ms' => 5));
$this->session->setTimeouts(array('type' => 'script', 'ms' => 5));
$this->session->setTimeouts(array('type' => 'page load', 'ms' => 5));

## Interacting with elements

Expand Down Expand Up @@ -370,7 +370,7 @@ $element = $session->element(PHPWebDriver_WebDriverBy::ID, $value);

## Profiles

* To send a Firefox profile over the wire to a remote Se server. It is up to you to configure it how you want.
* To send a Firefox profile over the wire to a remote The server. It is up to you to configure it how you want.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the original text was more correct, and not a typo, as "Se" was likely shorthand for "Selenium". Is your fix a typo here (e.g. "The"). Should leave term out making it "remote server" or insert/replace with "Selenium" (or "WebDriver").


```php
$driver = new PHPWebDriver_WebDriver();
Expand Down