fuzz-tests: Improve the fuzz-base32-64 test #8183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morehouse
suggested changes
Apr 11, 2025
Contributor
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
This PR is broken. Running on the existing corpus triggers a UBSan error:
tests/fuzz/fuzz-base32-64.c:25:2: runtime error: null pointer passed as argument 1, which is declared to never be null
morehouse
reviewed
Apr 15, 2025
Contributor
morehouse
left a comment
morehouse
left a comment
There was a problem hiding this comment.
Code changes LGTM.
I think the Changelog-Added in the first commit should be a Changelog-None though, since this is a test-only change.
Also, did you use the run.py script to minimize the number of new inputs added to the corpus?
Changelog-None: Currently, fuzz testing for b64_encode() merely encodes input and frees the result, providing no real verification of its behavior. Introduce a new b64_decode() function (modeled after b32_decode()) and update the fuzz test to perform a roundtrip—encoding followed by decoding—to ensure that b64_encode() correctly preserves the original data.
Author
I've made this change in the latest push.
Yes. |
4 tasks
Change in the fuzz-testing scheme of fuzz-base32-64 led to the discovery of test inputs that result in greater in code-coverage. Add these inputs to the test's seed corpus.
Author
|
The seed corpus additions are now rectified to be minimal. |
Contributor
|
ACK b4119e3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, fuzz testing for
b64_encode()in thefuzz/fuzz-base32-64test merelyencodes input and frees the result, providing no real verification of its behavior.
Introduce a new
b64_decode()function and update the fuzz test to perform aroundtrip—encoding followed by decoding—to ensure that
b64_encode()correctly preserves the original data.
Add the newly discovered inputs that result in greater code-coverage to the
seed corpus for this test.