make: remove plugins/clnrest dir prior to building clnrest #8201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endothermicdev
force-pushed
the
remove-clnrest-build-dir
branch
2 times, most recently
from
f212d3e to
3d12bb9
Compare
When building in the same directory used for <=v24.11, this would occur: cp: cannot create regular file plugins/clnrest: Permission denied make: *** [plugins/Makefile:149: plugins/clnrest] Error 1 make: *** Waiting for unfinished jobs.... Remove the old directory so the new rust binary can take its place. Changelog-Fixed: `make` cleans up old clnrest directory prior to building the new plugin.
endothermicdev
force-pushed
the
remove-clnrest-build-dir
branch
from
3d12bb9 to
5e1dbca
Compare
Merged
|
Closing this PR as the change has already been merged with PR #8159. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #8159, this should be the last step to cleaning up traces of the old plugin during build -
make cleanandmake installhave already been addressed.When building in the same directory used for <=v24.11, this would occur:
cp: cannot create regular file plugins/clnrest: Permission denied
make: *** [plugins/Makefile:149: plugins/clnrest] Error 1
make: *** Waiting for unfinished jobs....
Remove the old directory so the new rust binary can take its place.
Changelog-Fixed:
makecleans up old clnrest directory prior to building the new plugin.Important
25.02 FREEZE JANUARY 31ST: Non-bugfix PRs not ready by this date will wait for 25.05.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: