Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cln-rpc/Makefile: fix typo CLN_RPC_GEN_ALL=>CLN_RPC_GENALL #8212

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

whitslack
Copy link
Collaborator

I noticed a typo in cln-rpc/Makefile while trying to hunt down why Make was remaking targets.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

@whitslack whitslack requested a review from cdecker as a code owner April 5, 2025 05:46
@whitslack
Copy link
Collaborator Author

Also, shouldn't cln-grpc/Makefile be included from somewhere? It's not. Thus, make cln-grpc-all leads to…

make: *** No rule to make target 'cln-grpc-all'.  Stop.

It looks like include cln-grpc/Makefile should go inside the ifneq ($(RUST),0) block in the root Makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant