Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "exceeding amount_msat" check #356

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

Impa10r
Copy link
Contributor

@Impa10r Impa10r commented Feb 14, 2025

#355

Replace <= with <

@YusukeShimizu
Copy link
Contributor

Thank you for the revisions.
I believe it’s correct to allow for situations where sp (spendable amount) and rs (receivable amount) are exactly the same.

However, the spendable amount is also checked again when executing PayFeeInvoiceAction. In order to implement the intended changes, wouldn’t the modification also be necessary?

if sp <= requiredBalance {

@Impa10r
Copy link
Contributor Author

Impa10r commented Feb 15, 2025

However, the spendable amount is also checked again when executing PayFeeInvoiceAction. In order to implement the intended changes, wouldn’t the modification also be necessary?

if sp <= requiredBalance {

agree, did not notice

Copy link
Contributor

@YusukeShimizu YusukeShimizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@YusukeShimizu YusukeShimizu merged commit 73e8c75 into ElementsProject:master Feb 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants