Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[json] Skip bulk data URI when deserializing JSON #472

Merged
merged 2 commits into from
Apr 13, 2024
Merged

[json] Skip bulk data URI when deserializing JSON #472

merged 2 commits into from
Apr 13, 2024

Conversation

feliwir
Copy link
Contributor

@feliwir feliwir commented Mar 11, 2024

Relates to #470

@Enet4 Enet4 added enhancement A-lib Area: library C-json Crate: dicom-json labels Mar 16, 2024
Enet4
Enet4 reviewed Mar 16, 2024
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just adding a few recommendations inline.

json/src/de/mod.rs Outdated Show resolved Hide resolved
json/src/de/mod.rs Outdated Show resolved Hide resolved
@Enet4 Enet4 changed the title [json] Skip bulk data when deserializing JSON [json] Skip bulk data URI when deserializing JSON Apr 13, 2024
Enet4
Enet4 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The next step would be a DICOM object implementation that can hole bulk data URIs, which can be worked on at its own pace. Thank you @feliwir!

@Enet4 Enet4 merged commit f2674fc into Enet4:master Apr 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
A-lib Area: library C-json Crate: dicom-json enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feliwir @Enet4