new properties to form and TextInput widget for keyboard dissmiss control #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,6 +68,7 @@ class EnsembleForm extends StatefulWidget | |||
| _controller.labelStyle = Utils.getTextStyle(value), | |||
| 'enabled': (value) => _controller.enabled = Utils.optionalBool(value), | |||
| 'readOnly': (value) => _controller.readOnly = Utils.optionalBool(value), | |||
| 'dismissKeyboardOnSubmit': (value) => _controller.dismissKeyboardOnSubmit = Utils.getBool(value, fallback: true), | |||
There was a problem hiding this comment.
fallback should be from the controller, don't duplicate the same thing,
try this
'dismissKeyboardOnSubmit': (value) => _controller
.dismissKeyboardOnSubmit =
Utils.getBool(value, fallback: _controller.dismissKeyboardOnSubmit),
sharjeelyunus
approved these changes
Feb 26, 2025
| @@ -110,6 +111,7 @@ class FormController extends WidgetController { | |||
| String? labelOverflow; | |||
| bool? enabled; | |||
| bool? readOnly; | |||
| bool dismissKeyboardOnSubmit = true; | |||
There was a problem hiding this comment.
also use the same property name for both, form and textinput
dismissibleKeyboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1867
Demo Video:
https://github.com/user-attachments/assets/b6977565-88c6-4d38-8ac5-6e15265f526c
CC: @ridsashabbir @sharjeelyunus