New Widget: Tag Input #1893
Open
New Widget: Tag Input #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -144,6 +145,7 @@ class WidgetRegistry { | |||
| RadioButton.type: () => RadioButton(), | |||
| EnsembleForm.type: () => EnsembleForm(), | |||
| TextInput.type: () => TextInput(), | |||
| TagInput.type: () => TagInput(), | |||
There was a problem hiding this comment.
please don't register new widgets in legacyWidgetMap, this should be registered in _registeredWidgets map
Comment on lines
10
to
35
| import 'package:ensemble/framework/action.dart'; | ||
| import 'package:ensemble/framework/widget/widget.dart'; | ||
| import 'package:ensemble/layout/form.dart'; | ||
| import 'package:ensemble/model/item_template.dart'; | ||
| import 'package:ensemble/screen_controller.dart'; | ||
| import 'package:ensemble/util/debouncer.dart'; | ||
| import 'package:ensemble/util/input_formatter.dart'; | ||
| import 'package:ensemble/util/input_validator.dart'; | ||
| import 'package:ensemble/util/utils.dart'; | ||
| import 'package:ensemble/widget/helpers/HasTextPlaceholder.dart'; | ||
| import 'package:ensemble/widget/helpers/form_helper.dart'; | ||
| import 'package:ensemble/widget/helpers/input_wrapper.dart'; | ||
| import 'package:ensemble/widget/helpers/widgets.dart'; | ||
| import 'package:ensemble_ts_interpreter/invokables/invokablecontroller.dart'; | ||
| import 'package:flutter/cupertino.dart'; | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:ensemble/layout/templated.dart'; | ||
| import 'package:ensemble_ts_interpreter/invokables/invokable.dart'; | ||
| import 'package:email_validator/email_validator.dart'; | ||
| import 'package:ensemble/framework/model.dart' as model; | ||
| import 'package:flutter/services.dart'; | ||
| import 'package:flutter_html/flutter_html.dart'; | ||
| import 'package:flutter_i18n/flutter_i18n.dart'; | ||
| import 'package:form_validator/form_validator.dart'; | ||
| import 'package:mask_text_input_formatter/mask_text_input_formatter.dart'; | ||
| import 'package:fluttertagger/fluttertagger.dart'; |
There was a problem hiding this comment.
why are there so many unused imports here? please only import the package/file which are required
we can do this, I'll make the common util for text and tag input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1825
Example
Demo:
Screen.Recording.2025-02-28.at.7.23.53.PM.mov
CC: @sharjeelyunus @ridsashabbir