Loading State for camera overlay capture #1918
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+520
to
+521
| child: CircularProgressIndicator( | ||
| color: Colors.white, // Optional: Change the color of the progress indicator |
There was a problem hiding this comment.
shouldn't we allow user to build his own loading indicator? if loading widget is not defined we can use this as default, but user should have the option to define his own widget for customization
There was a problem hiding this comment.
Yeah we can have custom widget.
Comment on lines
+1042
to
+1052
| setState(() { | ||
| isCropping = true; | ||
| }); | ||
| try { | ||
| file = await takeOverlayCapture(); | ||
| } on Exception catch (e) { | ||
| print(e); | ||
| } finally { | ||
| setState(() { | ||
| isCropping = false; | ||
| }); |
There was a problem hiding this comment.
based on the video in PR, this is taking too much time, is there a way to optimize this? maybe doing a something in background, please checkout why its taking that much time, we can push this for now, but there should be way to optimize take
There was a problem hiding this comment.
Actually there's image encoding decoding going on there and also file reading too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Ticket: #1913
While processing image to crop for overlay Widget
Cameragoes intoloading state.So application doesn't seems like stuck.
cameraLoading.mp4