feat: codegen without embedding runtime pointers into body #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/cleanup_codegen
branch
from
e1ba496 to
0e827a8
Compare
wsmoses
reviewed
Mar 29, 2025
src/Compiler.jl
Outdated
| # XLA.compile mutates the module, for serialization we need to keep a copy | ||
| if serializable | ||
| iobuffer = IOBuffer() | ||
| show(iobuffer, mod) |
There was a problem hiding this comment.
we should show preserving debug info
wsmoses
approved these changes
Mar 29, 2025
avik-pal
force-pushed
the
ap/cleanup_codegen
branch
from
0e827a8 to
30cb230
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving the codegen changes part from #1083. We can land this and follow up with the serialization features