Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add !tqsmute and /tqsmute #189

Merged
merged 8 commits into from
Apr 27, 2024
Merged

Conversation

FloatingMilkshake
Copy link
Collaborator

This PR closes #168.

Adds two new commands, !tqsmute and /tqsmute, that Technical Queries Slayer members can use to temp-mute other members.

TQS members can provide a reason for the mute, but cannot change the duration, nor can they mute other TQS members or staff. Mute duration can be configured with tqsMuteDurationHours in config.json.

The tqsmute commands can only be used in tech support channels and their threads.
image

When TQS members use the slash command to mute a member, it is suggested that they create a modmail thread to provide moderators with context & prompt further mod action. Unfortunately this is not done when !tqsmute is used, as I wasn't sure what the best way to get this message across privately would be—ephemeral messages only work with slash commands, and I don't really like the idea of a DM.
image

TQS mutes are logged in the standard mod log channel, and are also sent to the investigations channel.
image

TQS mutes are stored in the db the same way regular mutes are. There is no special flag in the db to identify that they are TQS mutes, but there is a note on the log in log channels (see above). If a moderator uses the mute command to apply a standard mute to a TQS-muted member, the mute in the db is overwritten.

This PR also updates the unmute command to remove both the standard Muted role and the TQS Muted role. There is not a separate command for removing TQS mutes only.

Copy link
Owner

@Erisa Erisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some review comments.

Also, currently if one leaves the server while TQS Muted it ends up removing the mute (even from the db), most likely there is some on server leave/join logic that is interfering.

Feel free to add a simple bool with default value to mute objects if you need a way to tell the difference between the two types.

@FloatingMilkshake
Copy link
Collaborator Author

All resolved. I hadn't thought to look at member join checks, but those consider the Muted role when checking whether to reapply a mute. Updated to also consider the TQS mute role.

@FloatingMilkshake FloatingMilkshake requested a review from Erisa March 4, 2024 04:14
@kotx
Copy link

kotx commented Apr 27, 2024

beans

@FloatingMilkshake FloatingMilkshake merged commit 6b771dc into main Apr 27, 2024
2 checks passed
@FloatingMilkshake FloatingMilkshake deleted the floatingmilkshake/tqs-tempmute branch April 27, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Todo: Fixed length tempmute command for TQS members
3 participants