forked from OffchainLabs/nitro
-
Notifications
You must be signed in to change notification settings - Fork 22
Solve the latestBaseFee taking a Nil value
#878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package espressotee | ||
|
|
||
| import ( | ||
| "math/big" | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| func TestBaseFeeCheck_NilBaseFee(t *testing.T) { | ||
| t.Run("retries when base fee is nil", func(t *testing.T) { | ||
| attempts := 0 | ||
| fn := func() (*big.Int, error) { | ||
| attempts++ | ||
| if attempts < 2 { | ||
| return nil, nil | ||
| } | ||
| return big.NewInt(1000000), nil // Succeed on 3rd retry | ||
| } | ||
|
|
||
| err := BaseFeeCheck(10000000, 3, 10*time.Millisecond, fn, "test") | ||
| if err != nil { | ||
| t.Errorf("Expected success after retry, got: %v", err) | ||
| } | ||
| if attempts != 2 { | ||
| t.Errorf("Expected 2 attempts, got %d", attempts) | ||
| } | ||
| }) | ||
|
|
||
| t.Run("fails when base fee always nil", func(t *testing.T) { | ||
| attempts := 0 | ||
| fn := func() (*big.Int, error) { | ||
| attempts++ | ||
| return nil, nil // Always nil | ||
| } | ||
|
|
||
| err := BaseFeeCheck(10000000, 3, 10*time.Millisecond, fn, "test") | ||
| if err == nil { | ||
| t.Error("Expected error when base fee always nil") | ||
| } | ||
| if attempts != 3 { | ||
| t.Errorf("Expected 3 attempts, got %d", attempts) | ||
| } | ||
| }) | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we consolidate these tests and make them small, we should not have so many tests just for a nil check I think. Trying to keep our CI times less :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for sure, that's why I added a little comment on slack. I knew this concern would come up 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
31988a5