Add new usage specific initializers for AttachmentsFeatureElementView#1165
Merged
dfeinzimer merged 1 commit intoFeatureFormView/UtilityNetworkAssociationFormElementfrom May 20, 2025
Merged
Conversation
mhdostal
approved these changes
May 20, 2025
CalebRas
approved these changes
May 20, 2025
Collaborator
CalebRas
left a comment
CalebRas
left a comment
There was a problem hiding this comment.
Looks good, thanks for fixing this!
dfeinzimer
merged commit d252c5c
into
FeatureFormView/UtilityNetworkAssociationFormElement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a crash introduced in #1160 by ensuring that an
InternalFeatureFormViewModelis present when needed.Unlike with an
ObservableObject, if an@Observableobject is not in the environment, such as is the case when usingAttachmentsFeatureElementViewin a popup, a fatal error is encountered:Note that
FormViewModelwas renamed toInternalFeatureFormViewModelafter #1160 in #1162.Thank you to @CalebRas for catching this new crash.