-
Notifications
You must be signed in to change notification settings - Fork 11
Fix DocC warnings #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DocC warnings #968
Conversation
the device to focus on specific content in the scene. To learn more about using the ``FlyoverSceneView`` see the <doc:FlyoverSceneViewTutorial>. | ||
the device to focus on specific content in the scene. To learn more see the <doc:FlyoverSceneViewTutorial>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that we should make this change because these symbol links are helpful on other platforms. We host the iOS docC archive, not the mac catalyst docC archive so these warnings aren't really valid for our use case. I remember reading through this AR doc and I found these links helpful. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had suggested to @des12437 that she remove them because component name is already provided via the paragraph headers.
Also it looks like these links aren't live on the current published web version so I'm not sure what the targeted platform is when the docs are built for hosting:
Hopefully DocC supports compiler directives of some sort eventually.
@mhdostal thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had suggested to @des12437 that she remove them because the component name is already provided via the paragraph headers.
I remember when I was reading this that I would read each paragraph then I would want to look at the API and there was no convenient way to get there other than search the type. Not a huge deal I just think the symbol links are a nice addition.
Also it looks like these links aren't live on the current published web version so I'm not sure what the targeted platform is when the docs are built for hosting:
Weird. I knew the SDK was iOS but I just assumed the same here, I can double-check this because now I am curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can double-check this because now I am curious.
Yeah looks like it is using the iOS DocC archive, hmm weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I know why. The symbol links were added in 200.6 and the doc you are looking at is for 200.5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wish there was a way to eliminate all possible warnings.
I agree with that 😮💨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can revert these changes for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully DocC supports compiler directives of some sort eventually.
Maybe we can log an issue like swiftlang/swift-docc#255 but specify our need to allow skipping certain symbols for visionOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can log an issue like swiftlang/swift-docc#255 but specify our need to allow skipping certain symbols for visionOS.
Good idea @yo1995. I can log an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves DocC warnings on Mac Catalyst caused by unrecognized symbol links.