Feature template picker

[rolson]

We have one of these in the objc toolkit.

This is an initial PR. I still need to add tests and a tutorial. Also the map that I use in the example is not a good map for this. I need to find a better map.

[rolson]

I added tests

[rolson]

ok, added tutorial now as well

[mhdostal]

I've tested this with the Feature Forms Micro App. It looks and works great! I noticed a couple of issues, which I've commented on. I'll look at the code in another go-round.

[rolson]

Actually, I'm going to look for a different solution because I'm not sure I like how it resizes some of these:

With the fix:

Before the fix:

[rolson]

Ok, I fixed the image size so that it will limit it to 50x50, but not enlarge the smaller icon sizes.

[mhdostal]

Ok, I fixed the image size so that it will limit it to 50x50, but not enlarge the smaller icon sizes.

The only issue I see with that is when Dynamic Type is used the text will increase in size but not the icons. That would be "nice-to-have", but it's not a dealbreaker for me.

I did add padding around the image to keep the size in check.

Image(uiImage: image)
    .resizable()
    .aspectRatio(contentMode: .fit)
    .padding(4)

Here's what it looks like with Dynamic Type:

And without it:

[rolson]

The only issue I see with that is when Dynamic Type is used the text will increase in size but not the icons. That would be "nice-to-have", but it's not a dealbreaker for me.

I'd rather have features that are under 50x50 draw correctly in their correct size. To me that's important. If there is a way to do that and let the larger features grow up to the dynamic font size, that would be ideal. But I couldn't find a way to do that unfortunately.

[philium]

The tool for that job is ScaledMetric.

[dfeinzimer]

Just 2 last comments and I think that'll be it.

[dfeinzimer]

Should the templates be sorted alphabetically by name?

Suggested change

	)
	}
	)
	infos.sort { $0.template.name < $1.template.name }
	}

[dfeinzimer]

Perhaps the sections too?

[rolson]

I'm not sure. I could see alphabetizing them. Currently it is in the order of layers and then the templates that the layers report. So I'm not sure what is desirable. @mhdostal do you recall what the obj-c based version did?

[mhdostal]

I'm not sure. I could see alphabetizing them. Currently it is in the order of layers and then the templates that the layers report. So I'm not sure what is desirable. @mhdostal do you recall what the obj-c based version did?

There was no sorting in the obj-c template picker.

[mhdostal]

One enhancement request would be to only show the templates that apply to a specific geometry type. In the Swft FF test app, we are only allowing creating point symbols, so limiting the feature templates to those supporting point geometries would be nice.

[rolson]

One enhancement request would be to only show the templates that apply to a specific geometry type. In the Swft FF test app, we are only allowing creating point symbols, so limiting the feature templates to those supporting point geometries would be nice.

Cool. Did the original template picker in the other toolkit do this as well?

[mhdostal]

One enhancement request would be to only show the templates that apply to a specific geometry type. In the Swft FF test app, we are only allowing creating point symbols, so limiting the feature templates to those supporting point geometries would be nice.

Cool. Did the original template picker in the other toolkit do this as well?

No, but it's something that I'm doing for the Swift Feature Form test app; we're not concerned with the full geometry-editing experience yet, so we're only supporting adding point features.

[dfeinzimer]

Updated the image. PR looks good 👍