Skip to content

Commit

Permalink
fix(popover, tooltip): change display to contents (#11384)
Browse files Browse the repository at this point in the history
**Related Issue:** #11378

## Summary

- change default display on `tooltip` and `popover` from `block` to
`contents`.


BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE
  • Loading branch information
driskull authored and benelan committed Feb 8, 2025
1 parent 2a2c755 commit 7d974de
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ import type { Popover } from "./popover";

describe("calcite-popover", () => {
describe("renders when closed", () => {
renders("calcite-popover", { display: "block" });
renders("calcite-popover", { display: "contents" });
});

describe("renders when open", () => {
renders(`<calcite-popover label="test" open reference-element="ref"></calcite-popover><div id="ref">😄</div>`, {
display: "block",
display: "contents",
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/

:host {
@apply block;
@apply contents;
--calcite-floating-ui-z-index: var(--calcite-popover-z-index, theme("zIndex.popover"));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ describe("calcite-tooltip", () => {
}

describe("renders", () => {
renders(`calcite-tooltip`, { display: "block" });
renders(`calcite-tooltip`, { display: "contents" });
renders(`<calcite-tooltip open reference-element="ref"></calcite-tooltip><div id="ref">😄</div>`, {
display: "block",
display: "contents",
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/

:host {
@apply block;
@apply contents;
--calcite-floating-ui-z-index: var(--calcite-tooltip-z-index, theme("zIndex.tooltip"));
}

Expand Down

0 comments on commit 7d974de

Please sign in to comment.