Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove liberty/use-logical-spec exception once stylelint's autofix + stylelint-disable lines works properly #9939

Closed
jcfranco opened this issue Aug 1, 2024 · 2 comments
Closed

remove liberty/use-logical-spec exception once stylelint's autofix + stylelint-disable lines works properly #9939

jcfranco opened this issue Aug 1, 2024 · 2 comments
Assignees
@DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Milestone
2025-02-06 - 3.0....

Comments

@jcfranco
Copy link
Member

jcfranco commented Aug 1, 2024

Priority impact

p - low

Summary

#9337 required adding exceptions to this rule for left/right CSS props (see 5ecc325) due to stylelint's autofix + disabling lines not meshing well.

We should roll back the exception once stylelint/stylelint#2643 is addressed and disable the rule only where it's explicitly needed.

Desired Outcome

For liberty/use-logical-spec to autofix all applicable props.

Resources

No response
@jcfranco jcfranco added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 1, 2024
@jcfranco jcfranco changed the title remove liberty/use-logical-spec exception once stylelint ignores remove liberty/use-logical-spec exception once stylelint's autofix + stylelint-disable lines works properly Aug 1, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Dec 30, 2024
@DitwanP DitwanP added this to the 2025-04-29 - Apr Milestone milestone Jan 3, 2025
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
@jcfranco jcfranco mentioned this issue Jan 22, 2025
Merged
@jcfranco jcfranco self-assigned this Jan 22, 2025
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jan 22, 2025
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 28, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem removed their assignment Feb 4, 2025
@DitwanP
Copy link
Contributor

DitwanP commented Feb 5, 2025

🍡 Verified locally

@DitwanP DitwanP closed this as completed Feb 5, 2025
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP