Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linting): drop liberty/use-logical-spec workaround for left/right props #11356

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 22, 2025

Related Issue: #9939

Summary

Stylelint properly supports disabling lines, so this workaround is no longer necessary.

@jcfranco jcfranco requested a review from benelan as a code owner January 22, 2025 01:12
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 22, 2025
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 28, 2025
@jcfranco jcfranco requested a review from driskull January 28, 2025 06:47
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 28, 2025
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

@jcfranco jcfranco merged commit 0d096e6 into dev Jan 28, 2025
15 checks passed
@jcfranco jcfranco deleted the jcfranco/drop-liberty/use-logical-spec-rule-workaround branch January 28, 2025 22:32
benelan pushed a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants