chore(actions): add icon leads notification for calcite-ui-icons requests #11263
Conversation
geospatialem
added
the
skip visual snapshots
github-actions
bot
added
the
chore
There was a problem hiding this comment.
Why are tagging icon designers in a comment instead of assigning them (or the @Esri/calcite-icon-designers team) to the issue? I think designers would be notified either way, but it assigning would reduce noise for the issue author.
Edit: Actually you can't assign a team to an issue. But assigning the individual designer(s) is still an option.
If we'd rather assign issues to the team, can alter the automation - the intent was to be similar to our new component and spike complete notifications, where:
|
There was a problem hiding this comment.
If we'd rather assign issues to the team, can alter the automation - the intent was to be similar to our new component and spike complete notifications, where:
- Icon leads would be notified and could review the request
- If the Icon team would like to proceed with the request, they could assign themselves to follow-up with the requestor once the icon(s) are added
- If the Icon team does not wish to proceed with the request, the issue would be closed with a response to the requestor
Gotcha. I don't remember why we decided to comment/mention instead of assign in previous workflows. Assigning would notify them as well, and would have the added benefit of reducing noise for the requester and showing up in the designer's list of assigned issues so things don't get lost.
We don't need to make the change in this PR, but it's something worth considering.
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
* origin/dev: (322 commits) chore: add ui icons package to enhancement template (#11344) chore(table): move workaround comment back to its usage (#11341) ci(actions): refine remove-issue-from-design-projects workflow (#11325) chore(actions): add icon leads notification for calcite-ui-icons requests (#11263) test(combobox): use async expect for non-throwing test case (#11332) fix(combobox, input-time-zone): fix initial item selection delay (#11326) build(deps): update dependency type-fest to v4.32.0 (#11308) chore(utility-network-layer, crosshair): add font codepoints (#11336) refactor(loadable): deprecate obsolete helpers (#11312) chore: release next feat: add crosshair (#11331) build(deps): update arcgis to ^4.32.0-next.81 (#11273) ci(actions): add action to remove issues from design projects (#11249) chore: release next fix(list-item): reflect the sortHandleOpen property (#11323) refactor(block): heading text color (#11314) chore: release next fix(list): only focus on row when clicking a list item (#11310) fix(tooltip, popover): honor prevented events (#11278) chore: release next ...
…ests (#11263) **Related Issue:** #9922 ## Summary Add automation to issues when the `calcite-ui-icons` label is added, where Icon team leads will receive an `@` notification via a comment, similar to the [new component label automation](#10382 (comment)) from the [notifyAboutNewComponent script](https://github.com/Esri/calcite-design-system/blob/dev/.github/scripts/notifyAboutNewComponent.js). cc @allieorth, @arowles
Related Issue: #9922
Summary
Add automation to issues when the
calcite-ui-iconslabel is added, where Icon team leads will receive an@notification via a comment, similar to the new component label automation from the notifyAboutNewComponent script.cc @allieorth, @arowles