Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): close tooltip when hovering out of an iframe #11600

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(tooltip): close tooltip when hovering out of an iframe #11600

wants to merge 2 commits into from
+26 −0

Conversation

driskull
Copy link
Member

Related Issue: #11091

Summary

  • Sets up an event listener on the document for when the pointer leaves the document
    • Closes tooltip when this occurs
  • This is to support a mouse moving out of an iframe with tooltips

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 20, 2025
@driskull driskull marked this pull request as ready for review February 24, 2025 18:23
macandcheese
macandcheese approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Is it possible / easy to add an example of this functionality to the local demos?

@driskull
Copy link
Member Author

@macandcheese added a demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @macandcheese